Actively reject clang < 4.0 during configure
Categories
(Firefox Build System :: General, task)
Tracking
(firefox-esr68 fixed, firefox69 fixed)
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr68+
|
Details |
There's a libclang test for bindgen, but we should reject the compiler in the first place. Bug 1394825 didn't do that.
Assignee | ||
Comment 1•5 years ago
|
||
Bug 1394825 bumped the minimum version of clang we use on automation,
for the base toolchain jobs, and there's a libclang test for bindgen,
but we should reject the compiler in the first place.
The check to do that works in both C and C++, contrary to the original
3.6 test that was checking a C++ feature ; the test was later changed
for 3.9, using a check that would have worked in both C and C++, but
the C exception was left around. We remove it now.
Comment 2•5 years ago
|
||
Comment 4•5 years ago
|
||
bugherder |
Assignee | ||
Comment 5•5 years ago
|
||
Comment on attachment 9070452 [details]
Bug 1557547 - Actively reject clang < 4.0 during configure.
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: This allows the patches from bug 1560044 to work without modification. It's also a useful cleanup, making trying to build with clang < 4.0 fail in a better way than what bug 1394825 did.
- User impact if declined: See above.
- Fix Landed on Version: 69
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Configure change only, covered with a very large number of unit tests.
- String or UUID changes made by this patch: N/A
Comment 6•5 years ago
|
||
Comment on attachment 9070452 [details]
Bug 1557547 - Actively reject clang < 4.0 during configure.
Needed for bug 1560044. Approved for 68.1esr.
Comment 7•5 years ago
|
||
bugherder uplift |
Description
•