Closed Bug 1395417 Opened 7 years ago Closed 7 years ago

Expose eglCreateDeviceANGLE and eglReleaseDeviceANGLE in GLLibraryEGL

Categories

(Core :: Graphics, enhancement)

Product:
Core
Component:
Graphics
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(2 files, 1 obsolete file)

patch - Expose eglCreateDeviceANGLE and eglReleaseDeviceANGLE
(deleted), patch
sotaro
: review+
Details | Diff | Splinter Review
patch - Fix Star against type
(deleted), patch
sotaro
: review+
Details | Diff | Splinter Review
eglCreateDeviceANGLE and eglReleaseDeviceANGLE needs to be exposed for Bug 1395107.
Blocks: 1395107
Assignee: nobody → sotaro.ikeda.g
Attachment #8902988 - Flags: review?(jgilbert)
Comment on attachment 8902988 [details] [diff] [review] patch - Expose eglCreateDeviceANGLE and eglReleaseDeviceANGLE Review of attachment 8902988 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/gl/GLLibraryEGL.h @@ +491,5 @@ > void* texture, > const EGLAttrib* attrib_list); > + // ANGLE_device_creation > + EGLDeviceEXT (GLAPIENTRY * fCreateDeviceANGLE) (EGLint device_type, > + void *native_device, Star against type, here and elsewhere.
Attachment #8902988 - Flags: review?(jgilbert) → review+
(In reply to Jeff Gilbert [:jgilbert] from comment #2) > Comment on attachment 8902988 [details] [diff] [review] > patch - Expose eglCreateDeviceANGLE and eglReleaseDeviceANGLE > > Review of attachment 8902988 [details] [diff] [review]: > ----------------------------------------------------------------- > > + // ANGLE_device_creation > > + EGLDeviceEXT (GLAPIENTRY * fCreateDeviceANGLE) (EGLint device_type, > > + void *native_device, > > Star against type, here and elsewhere. Thanks! I am going to update it.
Attachment #8902988 - Attachment is obsolete: true
Attachment #8903037 - Flags: review+
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9dedf8ea07cd Expose eglCreateDeviceANGLE and eglReleaseDeviceANGLE r=jgilbert
Attached patch patch - Fix Star against type (deleted) — — Splinter Review
There was fallouts of applying the comment. Very trivial fix.
Attachment #8903037 - Attachment is obsolete: true
Attachment #8903037 - Attachment is obsolete: false
Attachment #8903044 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: