Closed Bug 1396117 Opened 7 years ago Closed 7 years ago

stylo: test assertion failures after nscoord_MAX was changed to 1<<30 - 1 in bug 1383492

Categories

(Core :: CSS Parsing and Computation, defect, P3)

57 Branch
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- wontfix
firefox57 --- affected

People

(Reporter: cpeterson, Unassigned)

References

Details

The follow tests started failing after bug 1383492 landed layout/generic/crashtests/crashtests.list 561 asserts-if(stylo,2-8) load 944909-1.html layout/generic/crashtests/crashtests.list 144 asserts-if(stylo,2) load 387282-1.html layout/generic/crashtests/crashtests.list 402 asserts-if(stylo,2) load 541714-1.html # bug 634161 layout/generic/crashtests/crashtests.list 403 asserts-if(stylo,3) load 541714-2.html # bug 634161 layout/reftests/bugs/reftest.list 1583 asserts(1-2) asserts-if(styloVsGecko,3) == 582146-1.html about:blank layout/reftests/bugs/reftest.list 989 asserts(1) asserts-if(styloVsGecko,2) == 418574-1.html 418574-1-ref.html # bug 478135 layout/reftests/bugs/reftest.list 990 asserts(1) asserts-if(styloVsGecko,2) == 418574-2.html 418574-2-ref.html # bug 478135 layout/reftests/bugs/reftest.list 1050 asserts(3) asserts-if(styloVsGecko,6) != 427017-1.xhtml about:blank # crash test (needs reftest-paged). existing assertions are bug 457400. layout/reftests/bugs/reftest.list 606 asserts(4) asserts-if(styloVsGecko,8) == 368155-negative-margins-1.html 368155-negative-margins-1-ref.html # bug 387205 / bug 457397
The assertions for styloVsGecko looks legit, because we run the test page twice, it is expected to double the number of assertions.
It looks like the reftest asserts have been in Gecko since bug 472557 in 2010, so they are not a Stylo bug. The crashtest asserts in comment 0, however, are new Stylo-only asserts from bug 1383492.
Priority: -- → P3
All assertions here seem to have been fixed. Closing.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.