Enum, class, Function, Struct and Union: => enum XchgStoreOp { DoExchange, DoStore }; SplitEmptyFunction: true HashableValue() : value(UndefinedValue()) { } instead of {}

Comment on attachment 8905247 [details] Bug 1397453 - Adapt to some js braces coding style https://reviewboard.mozilla.org/r/177040/#review182290 ::: js/src/.clang-format:12 (Diff revision 1) > # We require 80-col comments and 99-col code. > CommentPragmas: "^" > > SortIncludes: false > +BreakBeforeBraces: Custom > +BraceWrapping: AfterControlStatement is only a boolean, do we have a way to specify to wrap the braces when we have a if statement with a multi-line condition aligned at the same level as the code? ::: js/src/.clang-format:15 (Diff revision 1) > SortIncludes: false > +BreakBeforeBraces: Custom > +BraceWrapping: > + AfterEnum: true > + AfterClass: true > + AfterFunction: true This one should be false for function definitions which are under classes declarations, and true for function definitions which out0side classes declarations, even if they are classes members. class Foo { void bar() { return 42; } }; — or — class Foo { void bar(); }; void Foo::bar() { return 42; } ::: js/src/.clang-format:18 (Diff revision 1) > + AfterEnum: true > + AfterClass: true > + AfterFunction: true > + AfterStruct: true > + AfterUnion: true > + SplitEmptyFunction: true Identically, This one should be false for function definitions which are under classes declarations, and true for function definitions which are outside classes declarations even if they are classes members.