Closed Bug 1397457 Opened 7 years ago Closed 7 years ago

Update mach to download clang-format 5.0

Categories

(Developer Infrastructure :: Source Code Analysis, enhancement)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox57 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 2 open bugs)

Details

Attachments

(5 files)

clang-format-5.0
(deleted), application/x-sharedlib
Details
clang-format-diff.py
(deleted), text/x-python
Details
Bug 1397457 - Update mach to download clang-format 5.0
(deleted), text/x-review-board-request
andi
: review+
Details
clang-format
(deleted), application/octet-stream
Details
clang-format.exe
(deleted), application/x-ms-dos-executable
Details
We now need version 5.0 as version 4.0 doesn't have the option SplitEmptyFunction causing: YAML:18:23: error: unknown key 'SplitEmptyFunction' SplitEmptyFunction: false
Attached file clang-format-5.0 (deleted) —
Built with 5.0 stable release (should be released in the next few days) using: cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release ../ && make clang-format
Attached file clang-format-diff.py (deleted) —
(In reply to Sylvestre Ledru [:sylvestre] from comment #3) > Andi, could you please build Windows & Mac for me please? merci :) > Sources: > http://http.debian.net/debian/pool/main/l/llvm-toolchain-5.0/llvm-toolchain- > 5.0_5.0.orig.tar.bz2 > http://http.debian.net/debian/pool/main/l/llvm-toolchain-5.0/llvm-toolchain- > 5.0_5.0.orig-clang.tar.bz2 > Thanks Sure i can build the Mac version, asap, the Win version it will take a little bit.
Flags: needinfo?(bpostelnicu)
Attached file clang-format (deleted) —
This is the macOS version built with release options.
Attached file clang-format.exe (deleted) —
Release version for Windows, the binary is 32bit to keep consistency across different windows architectures.
Thanks. Note for the future me: python tooltool.py add --visibility public /tmp/clang-format /tmp/clang-format.exe python ~/dev/mozilla/build-tooltool/tooltool.py upload "file" --authentication-file=.tooltool-token-clang-5.0 --message "Bug 1397457 - Update mach to download clang-format 5.0"
Comment on attachment 8905274 [details] Bug 1397457 - Update mach to download clang-format 5.0 https://reviewboard.mozilla.org/r/177076/#review182696
Attachment #8905274 - Flags: review?(bpostelnicu) → review+
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f7364d8ab9d4 Update mach to download clang-format 5.0 r=andi
https://hg.mozilla.org/mozilla-central/rev/f7364d8ab9d4
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee: nobody → sledru
Is this comment still relevant? # This is a temporary work around until clang 5.0 has been released with our changes.
https://hg.mozilla.org/integration/mozilla-inbound/rev/13bf76b84d857d5c149d7081490c8e0cfbfe8fc7 Bug 1397457 - Update mach to download clang-format 5.0 - Remove the deprecated comment r=trivial DONTBUILD
Indeed, thanks!
Product: Core → Firefox Build System
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: