Closed
Bug 1397527
Opened 7 years ago
Closed 7 years ago
thNotify.send shouldn't persist most "success" messages.
Categories
(Tree Management :: Treeherder, enhancement, P1)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: KWierso, Assigned: KWierso)
References
Details
Attachments
(1 file)
Bug 1391321 redid a few thNotify.send() calls, making a few of the success cases persist where they previously didn't persist (probably just a copy/paste of instances found elsewhere?).
Comment 1•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → wkocher
Assignee | ||
Updated•7 years ago
|
Attachment #8905301 -
Flags: review?(cdawson)
Updated•7 years ago
|
Comment 2•7 years ago
|
||
We did this because we get bug reports where "something didn't work" and no way to know which task was created. I guess it doesn't hurt too much to remove it again if it is causing annoyance. I'll try to work on some way to make both parties happy eventually.
Updated•7 years ago
|
Attachment #8905301 -
Flags: review?(cdawson) → review+
Comment 3•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/6d33a1e45f565c054921fe194bbc5c8349f1dca3
Bug 1397527 - Stop persisting some thNotify.send notifications (#2759)
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•