Closed
Bug 1398167
Opened 7 years ago
Closed 5 years ago
Remove the temporary fix on bug 1398043
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla71
People
(Reporter: tt, Assigned: tt)
References
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
tt
:
review+
|
Details | Diff | Splinter Review |
(deleted),
text/x-phabricator-request
|
Details |
Per bug 1398043 comment #28, we add temporary fix for not upgrading to 26 properly and we need to remove the code for it in the future (maybe Nightly 58?)
Updated•7 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•7 years ago
|
||
Remove the temporary fix (P2 patch in bug 1398043) for not upgrading successfully.
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8916495 -
Attachment is obsolete: true
Assignee | ||
Comment 3•7 years ago
|
||
Comment on attachment 8916500 [details] [diff] [review] Bug 1398167: Remove the temporary fix for not upgrading shema version from 25 to 26. r?bkelly Hi Ben, This patch is for removing the temporary fix in bug 1398043. That fix has been landed for a month ago, so I think it's okay to remove it.
Attachment #8916500 -
Flags: review?(bkelly)
Updated•7 years ago
|
Attachment #8916500 -
Flags: review?(bkelly) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Thanks for the review
Attachment #8916500 -
Attachment is obsolete: true
Attachment #8917231 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9cf194a1ae45 Remove the temporary fix for not upgrading shema version from 25 to 26. r=bkelly
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9cf194a1ae45
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Backout by ttung@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/143dafd60d99 Backed out changeset 9cf194a1ae45 for causing crash in assertion r=backout a=backout
Assignee | ||
Comment 8•7 years ago
|
||
Reopen this bug since the landed patch has been backout. I will reland the patch after few weeks or a month.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•7 years ago
|
Status: REOPENED → ASSIGNED
Assignee | ||
Updated•7 years ago
|
Assignee: ttung → nobody
Status: ASSIGNED → NEW
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
Comment 9•5 years ago
|
||
This has been sitting for 2 years.... we should remove the old code
Flags: needinfo?(htsai)
Assignee | ||
Comment 10•5 years ago
|
||
Will investigate this again. I cannot think of any problem for not landing this again now.
Assignee: nobody → shes050117
Flags: needinfo?(htsai)
Assignee | ||
Comment 11•5 years ago
|
||
Comment 12•5 years ago
|
||
Pushed by ttung@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ce8922acc5e3 Remove the temporary fix for not upgrading shema version from 25 to 26; r=asuth
Comment 13•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago → 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: mozilla58 → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•