Calixte Denizet (:calixte) Reporter
	Description • 7 years ago

This bug was filed from the Socorro interface and is 
report bp-76d0f168-f50a-4f1e-957f-1ce390171019.
=============================================================

There are 21 crashes in nightly 58 starting with buildid 20171013100112. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1398167.
By the way, there are 16 crashes with buildid 20171018100140.
The crash reason is always "MOZ_RELEASE_ASSERT(aSavedResponseOut->mValue.type() != ResponseType::Opaque)".


[1] https://hg.mozilla.org/mozilla-central/rev/9cf194a1ae45

	Tom Tung [:tt, :ttung] Assignee
	Comment 1 • 7 years ago

Honestly, I have no idea whether this is related to bug 1398167. 
Bug 1398167 removed the temporary fix for bug 1398043.
 

IIUC, some of users may used the Nightly with buildid 20170907220212 (where bug 1290481 landed and bug 1398043 happened).
Then, went to a website caching opaque response.
Next, they have not visited the website until buildid 20171013100112 (where 1398167 landed).

Because I *think* it only have a small chance to happen the condition I described above, I'll keep investigating this issue to ensure there is no anything that I miss. I'm going to backout the fix in bug 1398167 for now.

	Tom Tung [:tt, :ttung] Assignee
	Comment 2 • 7 years ago

(In reply to Tom Tung [:tt] from comment #1)
backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=143dafd60d9948b081d0c7dcf5439169f09c8631

	Tom Tung [:tt, :ttung] Assignee
	Comment 3 • 7 years ago

(In reply to Tom Tung [:tt] from comment #1)
I cannot find another reason the explain this. I guess the crash happens as mentioned at comment #1. 

Someone cached the opauqe response from a website with Nightly around buildid 20170907220212, so the response's padding size is empty.
Then, not caching the opaque repsonse from that website unitl bug 1398167 landed.

Close this bug and re-open bug 1398167 since I've backouted the patch in bug 1398167. I'll wait maybe another month and re-land the patch in bug 1398167.