Vasilica Tamas, QA [:vtamas] Reporter
	Description • 7 years ago

[Affected versions]:
Firefox 57.0a1 (20170912013600)

[Affected platforms]:
Windows 10 64-bit
Mac OS X 10.12.3
Ubuntu 16.04 32-bit

[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Go to about:config and set extensions.legacy.enabled to true.
3.Restart the browser.
4.Install the following legacy add-on: https://addons.mozilla.org/firefox/downloads/file/672156/ublock_origin-1.13.4-an+fx+sm+tb.xpi?src=version-history
5.Navigate to Add-ons Manager -> Extensions and click on “More” link in order to open the add-on details tab.


[Actual Results]:
[Expected Results]:
“Legacy” badge is properly displayed in add-on details tab.


[Actual Results]:
- “Legacy” badge is not aligned with the add-on name in details tab. 
- See attached screenshot.


[Regression Range]:
Last good revision: 9d2fb90da23683a14c4d7b947bc1e397567ca3c7
First bad revision: 9aa2e9106aa353198a228d32186c4a9cddfdcb21
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9d2fb90da23683a14c4d7b947bc1e397567ca3c7&tochange=9aa2e9106aa353198a228d32186c4a9cddfdcb21

Looks like the following bug has the changes which introduced the regression: Bug 1392532

	Andrew Swan [:aswan]
	Comment 1 • 7 years ago

Its not just the legacy badge.  This rule for instance is no longer applied which makes the extension title not very prominent:
http://searchfox.org/mozilla-central/rev/51eae084534f522a502e4b808484cde8591cb502/toolkit/themes/shared/extensions/extensions.inc.css#726

A bunch of Photon changes to about:preferences among other things have done collateral damage to about:addons and I don't think anybody has systematically gone through to see what else is broken.  Ugh.
Mark, this is pretty open-ended but can you take a look?

	Jim Mathies [:jimm]
	Comment 2 • 7 years ago

based on priority

	Mark Striemer [:mstriemer] Assignee
	Comment 4 • 7 years ago

This and bug 1397359 were regressed by bug 1397325, which has now been fixed. Backing out the change I did for bug 1397359 here.

	Mark Striemer [:mstriemer] Assignee
	Comment 5 • 7 years ago

Rather the regression was fixed in bug 1397325.

	Robert Helmer [:rhelmer]
	Comment 6 • 7 years ago
mozreview-review

Comment on attachment 8908922 [details]
Bug 1399110 - Fix legacy badge placement in about:addons detail

https://reviewboard.mozilla.org/r/180538/#review185688

	Pulsebot
	Comment 7 • 7 years ago

Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8aae08df567d
Fix legacy badge placement in about:addons detail r=rhelmer

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/8aae08df567d

	Vasilica Tamas, QA [:vtamas] Reporter
	Comment 9 • 7 years ago

I confirm that this issue is fixed on Firefox 57.0a1 (20170919220202) under Windows 10 64-bit and Mac OS X 10.12.3. “Legacy” badge is properly aligned with the add-on name in details tab.