Open
Bug 1399394
Opened 7 years ago
Updated 2 years ago
Support code coverage builds on Mac
Categories
(Testing :: Code Coverage, task)
Testing
Code Coverage
Tracking
(Not tracked)
NEW
People
(Reporter: marco, Unassigned)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Keywords: leave-open)
Attachments
(1 file)
|
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Updated•7 years ago
|
Assignee: nobody → jyuen1
|
Reporter | |
Comment 1•7 years ago
|
||
From bug 1381069 comment 8:
> Update: With the fix in Bug 1409747 (thanks :marco) applied locally to
> latest inbound, my osx ccov build finishes now - but when I startup Firefox
> it errors out with:
>
> Roberts-MacBook-Pro-1903:mozilla-unified rwood$ ./mach run
> 0:00.69
> /Users/rwood/mozilla-unified/obj-x86_64-apple-darwin16.7.0/dist/NightlyDebug.
> app/Contents/MacOS/firefox -no-remote -foreground -profile
> /Users/rwood/mozilla-unified/obj-x86_64-apple-darwin16.7.0/tmp/scratch_user
> Assertion failure: Storage<T>::initialized(), at
> /Users/rwood/mozilla-unified/obj-x86_64-apple-darwin16.7.0/dist/include/
> mozilla/ThreadLocal.h:225
I'll see if I can reproduce the same crash tomorrow or Friday.
|
|
Reporter | |
Comment 2•7 years ago
|
||
I've managed to get a working build using the following mozconfig:
> ac_add_options --disable-install-strip
> ac_add_options --disable-jemalloc
> ac_add_options --disable-elf-hack
> ac_add_options --enable-debug
> ac_add_options --enable-debug-symbols
> ac_add_options --disable-sandbox
> ac_add_options --enable-coverage
>
> export CFLAGS="--coverage"
> export CXXFLAGS="--coverage"
> export LDFLAGS="--coverage"
Revision: f7c7cb48610c.
Clang version: Apple LLVM version 9.0.0 (clang-900.0.38).
OS X version: 10.13.
|
|
Reporter | |
Updated•7 years ago
|
Assignee: jyuen1 → nobody
Mentor: mcastelluccio
|
|
Reporter | |
Updated•6 years ago
|
Assignee: nobody → mcastelluccio
Mentor: mcastelluccio
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 3•6 years ago
|
||
I've tested a build with mochitest-a11y (one of the fastest suites), after applying all patches from the current blocking bugs.
The JavaScript coverage looks sane, the C++ one is still missing a lot of files. I'll try downloading the gcda files from the test machines to figure out what's wrong with the C++ coverage.
|
|
Reporter | |
Comment 4•6 years ago
|
||
(In reply to Marco Castelluccio [:marco] from comment #3)
> I've tested a build with mochitest-a11y (one of the fastest suites), after
> applying all patches from the current blocking bugs.
> The JavaScript coverage looks sane, the C++ one is still missing a lot of
> files. I'll try downloading the gcda files from the test machines to figure
> out what's wrong with the C++ coverage.
Now that all the basic blocking bugs are fixed, I re-tested and both JS and C++ coverage looked fine.
|
||
Updated•6 years ago
|
|
|
Reporter | |
Comment 5•6 years ago
|
||
After we fix bug 1495683, we should start to schedule the build (at least weekly) so we notice regressions earlier.
|
|
Reporter | |
Comment 6•6 years ago
|
||
Attachment #9022242 -
Flags: review?(jmaher)
|
|
Reporter | |
Updated•6 years ago
|
Keywords: leave-open
|
||
Updated•6 years ago
|
Attachment #9022242 -
Flags: review?(jmaher) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d0fab4a52f7
Run Mac coverage builds on mozilla-central pushes, without running its tests. r=jmaher
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
|
||
Comment 9•5 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:marco, maybe it's time to close this bug?
Flags: needinfo?(mcastelluccio)
|
|
Reporter | |
Updated•5 years ago
|
Flags: needinfo?(mcastelluccio)
|
|
Reporter | |
Updated•5 years ago
|
Type: defect → task
|
|
Reporter | |
Updated•5 years ago
|
No longer blocks: code-coverage
|
|
Reporter | |
Updated•5 years ago
|
|
|
||
Comment 10•4 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:marco, maybe it's time to close this bug?
Flags: needinfo?(mcastelluccio)
|
|
||
Comment 12•4 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:marco, maybe it's time to close this bug?
Flags: needinfo?(mcastelluccio)
|
|
Reporter | |
Comment 13•4 years ago
|
||
This is still something we should do at some point.
Flags: needinfo?(mcastelluccio)
|
|
||
Comment 14•3 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:marco, maybe it's time to close this bug?
Flags: needinfo?(mcastelluccio)
|
|
Reporter | |
Updated•3 years ago
|
Flags: needinfo?(mcastelluccio)
|
|
||
Comment 15•3 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:marco, maybe it's time to close this bug?
Flags: needinfo?(mcastelluccio)
|
|
Reporter | |
Updated•3 years ago
|
Flags: needinfo?(mcastelluccio)
|
|
||
Comment 16•2 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:marco, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.
Flags: needinfo?(mcastelluccio)
|
|
Reporter | |
Updated•2 years ago
|
Flags: needinfo?(mcastelluccio)
|
|
Reporter | |
Updated•2 years ago
|
Assignee: mcastelluccio → nobody
Status: ASSIGNED → NEW
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•