Closed
Bug 1473531
Opened 6 years ago
Closed 6 years ago
GTest is permafailing on Mac coverage builds because it runs out of time
Categories
(Testing :: Code Coverage, defect)
Testing
Code Coverage
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: marco, Assigned: calixte)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
GTest is always running over 1200 seconds, which is the max run time for GTest.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → cdenizet
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 1•6 years ago
|
||
On Mac, the failing test is Sanity5DeathTest.
On Windows, the failure is different, I see "TEST-START Jemalloc.JunkPoison" then several "INFO - Running GTest tests..." followed by several "INFO - Finished running GTest tests.".
Let's make this bug for Mac and I've opened bug 1474254 for Windows.
No longer blocks: 1381163
Summary: GTest is permafailing on Windows and Mac coverage builds because it runs out of time → GTest is permafailing on Mac coverage builds because it runs out of time
Assignee | ||
Comment 2•6 years ago
|
||
:erahm, do you have an idea why this test (Sanity5DeathTest) is taking so much time on mac coverage builds ?
Flags: needinfo?(erahm)
Assignee | ||
Comment 3•6 years ago
|
||
The failing test is storage_DeadlockDetectorTest.storage_Sanity5DeathTest.
Assignee | ||
Comment 4•6 years ago
|
||
For now let's disable this test for macosx ccov builds.
Assignee | ||
Comment 5•6 years ago
|
||
GTest is permafailing because of this test (GTest is always running over 1200s).
Comment 6•6 years ago
|
||
(In reply to Calixte Denizet (:calixte) from comment #2)
> :erahm, do you have an idea why this test (Sanity5DeathTest) is taking so
> much time on mac coverage builds ?
My guess is something like bug 1331049, comment 42. I'm fine just disabling for gcov. It would help to have a log to look at.
Flags: needinfo?(erahm)
Comment 7•6 years ago
|
||
Comment on attachment 8990742 [details]
Bug 1473531 -- Disable gtest storage_DeadlockDetectorTest.storage_Sanity5DeathTest for macosx ccov build.
Nathan Froyd [:froydnj] has approved the revision.
https://phabricator.services.mozilla.com/D2032
Attachment #8990742 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8462a894a7fe
Disable gtest storage_DeadlockDetectorTest.storage_Sanity5DeathTest for macosx ccov build.
Keywords: checkin-needed
Comment 9•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•