Closed Bug 1400503 Opened 7 years ago Closed 7 years ago

No obvious way to edit presets saved with mach try

Categories

(Firefox Build System :: Task Configuration, task)

Product:
Firefox Build System
Component:
Task Configuration
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla58

People

(Reporter: bzbarsky, Assigned: ahal)

References

Details

Attachments

(2 files)

Bug 1400503 - [tryselect] Separate 'common_arguments' into groups sub-parsers can opt-in to,
(deleted), text/x-review-board-request
armenzg
: review+
Details
Bug 1400503 - [tryselect] Add an option to open the presets file in an editor,
(deleted), text/x-review-board-request
armenzg
: review+
Details
There's a way to save presets with --save. And then you can use a preset with --preset. But I see no way to edit a preset if you messed up the selection for it....
Note that this was for mach try fuzzy. I haven't tried what happens if you do "mach try syntax" with a --save that has the same name as an existing saved syntax preset.
Presets live in ~/.mozbuild/autotry.ini. Agree there should be a way to edit this from the command line, or it should at least be discoverable. The case where presets from different subcommands have the same name should work.
I meant I don't know what happens if you use the _same_ subcommand and --save with an existing preset name. Does it override the old value, or fail, or something else?
Ah, gotcha. It should overwrite any pre-existing value.
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Comment on attachment 8922937 [details] Bug 1400503 - [tryselect] Separate 'common_arguments' into groups sub-parsers can opt-in to, https://reviewboard.mozilla.org/r/194100/#review199590 Nice refactoring.
Attachment #8922937 - Flags: review?(armenzg) → review+
Comment on attachment 8922938 [details] Bug 1400503 - [tryselect] Add an option to open the presets file in an editor, https://reviewboard.mozilla.org/r/194102/#review199594
Attachment #8922938 - Flags: review?(armenzg) → review+
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7741abf30b9b [tryselect] Separate 'common_arguments' into groups sub-parsers can opt-in to, r=armenzg https://hg.mozilla.org/integration/autoland/rev/301666d1d339 [tryselect] Add an option to open the presets file in an editor, r=armenzg
https://hg.mozilla.org/mozilla-central/rev/7741abf30b9b https://hg.mozilla.org/mozilla-central/rev/301666d1d339
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #11) > https://hg.mozilla.org/mozilla-central/rev/7741abf30b9b This changeset adds code that references EmptyParser, but there is no such thing. That breaks `mach try empty`. I filed bug 1413374 to fix that.
Depends on: 1413374
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: