Closed
Bug 1413374
Opened 7 years ago
Closed 7 years ago
`mach try empty` is broken (ImportError: cannot import name EmptyParser)
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla58
People
(Reporter: jwatt, Assigned: ahal)
References
Details
Attachments
(1 file)
Seems like https://hg.mozilla.org/mozilla-central/rev/7741abf30b9b (bug 1400503) broke `mach try empty`. That changeset references EmptyParser, but there is no such thing, so I get:
ImportError: cannot import name EmptyParser
|
Assignee | |
Comment 1•7 years ago
|
||
Sorry, I think I messed up a rebase and accidentally clobbered the EmptyParser. I'll also add a test for |try empty| so this gets caught next time.
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•7 years ago
|
||
Ah no, I copied the parser from another file and neglected to change the name.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8924142 [details]
Bug 1413374 - [tryselect] Fix |mach try empty| regression and add a test,
https://reviewboard.mozilla.org/r/195400/#review200454
No test; so much fun! :)
+1
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8924142 [details]
Bug 1413374 - [tryselect] Fix |mach try empty| regression and add a test,
https://reviewboard.mozilla.org/r/195400/#review200458
Attachment #8924142 -
Flags: review?(armenzg) → review+
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9528ed506a11
[tryselect] Fix |mach try empty| regression and add a test, r=armenzg
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Updated•7 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•