Closed Bug 1400920 Opened 7 years ago Closed 7 years ago

The pocket section briefly shows up and causes the scrollbar to make the whole page flicker

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 58
Tracking Status
firefox57 --- fixed
firefox58 --- fixed

People

(Reporter: florian, Assigned: Mardak)

References

Details

User Story

https://github.com/mozilla/activity-stream/compare/firefox-57b4...firefox-57b5

Attachments

(3 files)

Attached video Screen recording (deleted) —
See attached video. Somehow I can only reproduce this when opening new windows, I don't see it with the first window during startup. There are 7 frames where the activity stream about:home page is displayed with an empty Pocket section, causing a vertical scrollbar. Then it disappears, the scrollbar too, and everything else shifts to the right due to the space freed by the scrollbar.
Attached image Screenshot (deleted) —
(In reply to Florian Quèze [:florian] [:flo] from comment #0) > Somehow I can only reproduce this when opening new > windows, I don't see it with the first window during startup. Actually I just saw it during startup now.
Comment on attachment 8913266 [details] Bug 1400920 - The pocket section briefly shows up and causes the scrollbar to make the whole page flicker. https://reviewboard.mozilla.org/r/184648/#review189830 Thanks!
Attachment #8913266 - Flags: review?(usarracini) → review+
Pushed by edilee@gmail.com: https://hg.mozilla.org/integration/autoland/rev/dd4eea6b8ae4 The pocket section briefly shows up and causes the scrollbar to make the whole page flicker. r=ursula
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Verified fixed on Nightly 58.0a1 20170929100122
Status: RESOLVED → VERIFIED
Blocks: 1404345
User Story: (updated)
Comment on attachment 8913266 [details] Bug 1400920 - The pocket section briefly shows up and causes the scrollbar to make the whole page flicker. Approval Request Comment [Feature/Bug causing the regression]: Activity Stream prerendering [User impact if declined]: Users who don't see Pocket (only shown for US/CA/DE) might see content jumping around horizontally as scrollbars appear then disappear. [Is this code covered by automated tests?]: No, this is just a css change [Has the fix been verified in Nightly?]: Yes, 20170929100122 [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: Not really [Why is the change risky/not risky?]: Only changing 1 line of css (and strings) [String changes made/needed]: Pontoon localized strings were added that are not exposed for localization via mozilla-central
Attachment #8913266 - Flags: approval-mozilla-beta?
Blocks: 1394533
Why do we have unrelated string changes in this patch?
Flags: needinfo?(edilee)
flod suggested that we keep the strings up to date through the beta 57 cycle, but I can just manually edit the patch to not have strings, but the manual steps could introduce risk in the activity stream export process. Should I reattach a manually edited export patch without strings and request uplift a strings-only patch later in the beta process?
Flags: needinfo?(edilee) → needinfo?(sledru)
Yeah, clearly, I would like a bug == one issue being fixed, no unrelated changes.
Flags: needinfo?(sledru)
Depends on: 1405051, 1405050
Comment on attachment 8913266 [details] Bug 1400920 - The pocket section briefly shows up and causes the scrollbar to make the whole page flicker. This is needed to fix Bug 1404345, Beta57+
Attachment #8913266 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
User Story: (updated)
(In reply to Ed Lee :Mardak from comment #9) > [Is this code covered by automated tests?]: No, this is just a css change > [Has the fix been verified in Nightly?]: Yes, 20170929100122 > [Needs manual test from QE? If yes, steps to reproduce]: No Setting qe-verify- based on Ed's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: