Comment on attachment 8912879 [details] Bug 1403215 - Fix broken Snippets pref, perceived performance and bug fixes to Activity Stream. https://reviewboard.mozilla.org/r/184206/#review189356 Looks good, thanks!

Pushed by edilee@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b31be2f4c9b4 Fix broken Snippets pref, perceived performance and bug fixes to Activity Stream. r=ursula

I had to back this out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=133665246&repo=autoland So far it seems exclusive to Mac builds.

Backout by kwierso@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a23e9449a6f4 Backed out changeset b31be2f4c9b4 for mac failures in browser_newtab_focus.js a=backout

Comment on attachment 8912879 [details] Bug 1403215 - Fix broken Snippets pref, perceived performance and bug fixes to Activity Stream. https://reviewboard.mozilla.org/r/184206/#review189472

Pushed by edilee@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e3221268f8fc Fix broken Snippets pref, perceived performance and bug fixes to Activity Stream. r=k88hudson,ursula

Tracked due to https://bugzilla.mozilla.org/show_bug.cgi?id=1393489#c26

Comment on attachment 8912879 [details] Bug 1403215 - Fix broken Snippets pref, perceived performance and bug fixes to Activity Stream. Approval Request Comment [Feature/Bug causing the regression]: Activity Stream has had a pref option to turn off Snippets. [User impact if declined]: Users turning off the Snippets pref will still see a snippet or notification thinking the pref is broken. Also for perceived performance, users might see content jumping around vertically. [Is this code covered by automated tests?]: Yes, Activity Stream has 100% javascript line coverage [Has the fix been verified in Nightly?]: Yes, 20170929100122 [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: Not too risky [Why is the change risky/not risky?]: The primary change is additionally setting appropriate prefs and allowing Snippets service to control that behavior remotely (which no snippets use right now outside of testing), but if there is a problem, Snippets service would just not use the API without requiring Firefox changes) [String changes made/needed]: Pontoon localized strings were added that are not exposed for localization via mozilla-central

Just like with bug 1404345, having several changes at once is making our life much harder. Could you please split the changes?

What needs to be split? The strings? That's how we've been exporting strings and flod says we want to keep them up to date until end of the beta cycle as some localizers are translating now that it's in beta. https://bugzilla.mozilla.org/show_bug.cgi?id=1402529#c7

For the description, you are fixing at least three things: 1) Fix broken Snippets pref 2) perceived performance 3) bug fixes (which you don't describe) We would need a specific bug for every item + split 3).

Comment on attachment 8912879 [details] Bug 1403215 - Fix broken Snippets pref, perceived performance and bug fixes to Activity Stream. This is needed to fix Bug 1404345, Beta57+

(In reply to Ed Lee :Mardak from comment #13) > [Is this code covered by automated tests?]: Yes, Activity Stream has 100% > javascript line coverage > [Has the fix been verified in Nightly?]: Yes, 20170929100122 > [Needs manual test from QE? If yes, steps to reproduce]: No Setting qe-verify- based on Ed's assessment on manual testing needs and the fact that this fix has automated coverage.