Closed
Bug 1401763
Opened 7 years ago
Closed 7 years ago
Fix 8 byte content process leak
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
DUPLICATE
of bug 1401412
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
(Whiteboard: [MemShrink])
At some point, we weren't leaking anything in the content process, but I guess whatever patch got us to that point did not reduce the leak threshold, so at some point a leak was introduced. Fortunately, it is just a single nsTArray_base. I don't see this on release, so I think it was introduced in 57. I'll try to bisect it on treeherder. I tried to use XPCOM_MEM_LOG_CLASSES but I got a fatal assert almost immediately.
Assignee | ||
Updated•7 years ago
|
Whiteboard: [MemShrink]
Assignee | ||
Comment 1•7 years ago
|
||
Bisecting through m-c on TreeHerder, it was this push that introduced the nsTArray leak:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=b4c1ad9565ee9d00d96501c4a83083daf25c1413&filter-searchStr=linux%20x64%20debug%20mochitest
Oddly, on some earlier pushes, including one as late as "Wed Sep 6, 2:24:33." there was a larger leak involving some cookie stuff! But then it got fixed briefly, then the nsTArray leak started. (We really need to reduce the leak threshold to zero...)
Assignee | ||
Comment 2•7 years ago
|
||
It looks like bug 1390044 caused this. Specifically, this changeset:
https://hg.mozilla.org/mozilla-central/rev/665ea291fce4
Blocks: 1390044
Comment 3•7 years ago
|
||
Is this the thing mrbkap just fixed.
Comment 5•7 years ago
|
||
smaug is referring to bug 1401412 which does ensure that we destroy an nsTArray before XPCOM shutdown instead of after. Andrew, can you see if that changeset fixes this?
Flags: needinfo?(mrbkap) → needinfo?(continuation)
Assignee | ||
Comment 6•7 years ago
|
||
It does look like this leak has gone away, thanks!
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(continuation)
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•