Closed Bug 1390044 Opened 7 years ago Closed 7 years ago

Enable the input event queue on nightly

Categories

(Core :: DOM: Events, enhancement)

Product:
Core
Component:
DOM: Events
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: stone, Assigned: stone)

References

Details

(Keywords: perf)

Attachments

(1 file, 1 obsolete file)

Enable the input event queue on nightly
(deleted), patch
stone
: review+
Details | Diff | Splinter Review
No description provided.
Depends on: 1389314, 1351148, 1383485, 1383573, 1386791
Assignee: nobody → sshih
Any tab, even about:newtab and homepage, crashes in Nightly 18-08-17 as soon as I open it with prioritized_input_events.enabled set to true. Crash report: https://crash-stats.mozilla.com/report/index/bp-0723b4e1-bd79-40f0-810f-6d1850170818 I got no idea where to report this bug so I am sorry if I did something wrong.
(In reply to ajfhajf from comment #1) > I got no idea where to report this bug so I am sorry if I did something > wrong. Thanks for commenting! It looks like bug 1391657 has been filed for this issue.
Attached patch Enable the input event queue on nightly (obsolete) (deleted) — — Splinter Review
Attachment #8903416 - Flags: review?(bugs)
Have you checked whether https://bugzilla.mozilla.org/show_bug.cgi?id=1386791 will occur again if the pref is enabled?
Comment on attachment 8903416 [details] [diff] [review] Enable the input event queue on nightly This is conditional r+, assuming that bug 1386791 doesn't happen again. And this pref shouldn't be enabled the same day as the mousemove coalescing pref.
Attachment #8903416 - Flags: review?(bugs) → review+
Tried to enable the input event queue and re-triggered talos https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=b369b091b8a1b76a91278efc3513b136a2a225e2&newProject=try&newRevision=5d9407065d40d5d69670a3ca0ba58f1f2d2fdbb8&framework=1&showOnlyImportant=0 The result looks ok to me. Didn't find performance degradation. I'm going to enable it on nightly.
Depends on: 1397161
Added reviewer info.
Attachment #8903416 - Attachment is obsolete: true
Attachment #8904982 - Flags: review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/665ea291fce4 Enable the input event queue on nightly. r=smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/665ea291fce4
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Depends on: 1401763
Depends on: 1411604
Depends on: 1504692
No longer depends on: 1504692
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: