Closed Bug 1404224 Opened 7 years ago Closed 7 years ago

fsanitize=enum (ubsan) runtime errors for nsCSSTokenSerializationType

Categories

(Core :: CSS Parsing and Computation, defect, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: arthur, Assigned: arthur)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor])

Attachments

(1 file)

0001-Bug-1404224-Fix-ubsan-runtime-error-for-nsCSSTokenSe.patch
(deleted), patch
heycam
: review+
Details | Diff | Splinter Review
Running automated tests with fsanitize=enum results in errors like: > [task 2017-09-25T00:48:33.567Z] 00:48:33 INFO - REFTEST INFO | SET PREFERENCE pref(layout.css.servo.enabled,false) > [task 2017-09-25T00:48:33.567Z] 00:48:33 INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/variables/variable-declaration-48.html | 1929 / 1937 (99%) > [task 2017-09-25T00:48:33.588Z] 00:48:33 INFO - /builds/worker/workspace/build/src/layout/style/CSSVariableResolver.cpp:157:40: runtime error: load of value 32765, which is not a valid value for type 'nsCSSTokenSerializationType' > [task 2017-09-25T00:48:33.589Z] 00:48:33 INFO - /builds/worker/workspace/build/src/layout/style/CSSVariableResolver.cpp:157:40: runtime error: load of value 3506570800, which is not a valid value for type 'nsCSSTokenSerializationType' > [task 2017-09-25T00:48:33.590Z] 00:48:33 INFO - /builds/worker/workspace/build/src/layout/style/CSSVariableValues.h:105:10: runtime error: load of value 3506570800, which is not a valid value for type 'nsCSSTokenSerializationType' > [task 2017-09-25T00:48:33.591Z] 00:48:33 INFO - /builds/worker/workspace/build/src/layout/style/CSSVariableValues.h:105:10: runtime error: load of value 32765, which is not a valid value for type 'nsCSSTokenSerializationType' > [task 2017-09-25T00:48:33.591Z] 00:48:33 INFO - /builds/worker/workspace/build/src/layout/style/CSSVariableValues.cpp:95:32: runtime error: load of value 3506570800, which is not a valid value for type 'nsCSSTokenSerializationType' > [task 2017-09-25T00:48:33.592Z] 00:48:33 INFO - /builds/worker/workspace/build/src/layout/style/CSSVariableValues.cpp:96:31: runtime error: load of value 32765, which is not a valid value for type 'nsCSSTokenSerializationType'
Blocks: 1404547
Here's a patch that fixes the runtime errors. try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b89c25622003&selectedJob=134579805 (Patch is 4th commit from top. Bad Talos results are presumably unrelated.)
Assignee: nobody → arthuredelstein
Attachment #8914829 - Flags: review?(cam)
status-firefox57: --- → wontfix
Priority: -- → P3
Attachment #8914829 - Flags: review?(cam) → review+
Thanks for the review.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/30a40b41d590 Fix ubsan runtime error for nsCSSTokenSerializationType. r=heycam
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/30a40b41d590
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: