Closed
Bug 1404547
Opened 7 years ago
Closed 5 years ago
[meta] Enable 'enum' UBSan check
Categories
(Core :: Sanitizers, enhancement)
Core
Sanitizers
Tracking
()
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: arthur, Assigned: tsmith)
References
(Depends on 5 open bugs, Blocks 1 open bug)
Details
(Keywords: meta, Whiteboard: [tor])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
There are only a few more -fsanitize=enum in Mozilla's automated tests on the gcc Linux build. (See the bugs this bug depends on.) Once those are all fixed, we should be able to add the flags
`-fsanitize=enum -fno-sanitize-recover=enum`
to the debug build (or maybe the ASAN) build so that any future UBSAN enum errors are caught before they land.
This isn't a bmo bug, moving it somewhere slightly more appropriate.
Product: bugzilla.mozilla.org → Core
Version: Production → unspecified
|
Reporter | |
Comment 2•7 years ago
|
||
I ran an fsanitize=enum on a gcc build to see what errors are remaining.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d464e6aade11&selectedJob=134174002
I used the following script to download the logs files and extract and enumerate the runtime errors:
https://github.com/arthuredelstein/firefox-ubsan-errors
The results are as follows:
https://docs.google.com/spreadsheets/d/1yB5TR8TYBa8zNkNLo8UhsjjkzypVDCEtnNVAkE23yLo/edit?usp=sharing
|
|
Reporter | |
Updated•7 years ago
|
|
||
Updated•7 years ago
|
Summary: Add -fsanitize=enum to debug build → [meta] Add -fsanitize=enum to debug build
|
|
Reporter | |
Comment 3•7 years ago
|
||
Running -fsanitize=enum on linux64-asan (clang) detected 5 more enum error locations that gcc didn't detect. :P
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → twsmith
|
|
Assignee | |
Comment 4•5 years ago
|
||
Things have changed a bit since this bug was initially opened. Instead of adding the check to debug builds we will enable it on the ASan + UBSan builds.
Component: General → Security
Summary: [meta] Add -fsanitize=enum to debug build → [meta] Enable 'enum' UBSan check
|
|
Assignee | |
Comment 5•5 years ago
|
||
Pushed by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4af4d32ee984
Enable 'enum' UBSan check. r=froydnj
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
|
||
Comment 9•5 years ago
|
||
Backed out changeset 4af4d32ee984 for causing wpt leaks.
Backout link: https://hg.mozilla.org/integration/autoland/rev/b686373c4c6da27d6fd2516900463df5af709159
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291593371&repo=autoland&lineNumber=29708
Status: RESOLVED → REOPENED
status-firefox75:
fixed → ---
Resolution: FIXED → ---
Target Milestone: mozilla75 → ---
|
|
Assignee | |
Comment 10•5 years ago
|
||
|
||
Updated•5 years ago
|
Attachment #9130596 -
Attachment is obsolete: true
|
||
Comment 11•5 years ago
|
||
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a007d28149d
Enable 'enum' UBSan check. r=froydnj,mccr8
|
||
Comment 12•5 years ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in
before you can comment on or make changes to this bug.
Description
•