Closed
Bug 1404796
Opened 7 years ago
Closed 7 years ago
On mac, the app name is "FirefoxNightly" when it should be "Firefox Nightly"
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox58 wontfix, firefox59 fixed)
RESOLVED
FIXED
mozilla59
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
I thought the build system would use the other package names but it isn't.
For now, if MOZ_APP_DISPLAYNAME = "Firefox Nightly", the build will fail with:
05:34:57 ERROR - mozinstall.mozinstall.InstallError: Failed to install "/Users/cltbld/tasks/task_1505306020/installer.dmg ([Errno 2] No such file or directory: '/Volumes/Firefox')"
Because we are doing some parsing of the output of the "hdiutil" command [1] and the output varies, we have to do some better parsing of the output.
[1] https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozinstall/mozinstall/mozinstall.py#281
Comment 1•7 years ago
|
||
Firefox Developer Edition also has the same bug.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
Stephen, what do you think? I guess this will retrigger again the warning about the default browser.
Flags: needinfo?(spohl.mozilla.bugs)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sledru
Comment 4•7 years ago
|
||
Yes, it will retrigger the bug. But if we want to change the name, it has to be "Firefox Nightly" with a space. What happens if you escape the space, i.e. MOZ_APP_DISPLAYNAME = "Firefox\ Nightly"
Flags: needinfo?(spohl.mozilla.bugs)
Assignee | ||
Comment 5•7 years ago
|
||
I think I fixed this issue in bug 1404480.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•7 years ago
|
||
https://hg.mozilla.org/projects/oak/rev/e8f2721a1f1f588e7e12cb84d2c1542c9ef87985
Bug 1404796 - Add space in the Display name of Firefox {Nightly, Developer Edition}
Assignee | ||
Updated•7 years ago
|
status-firefox59:
--- → affected
Assignee | ||
Updated•7 years ago
|
Attachment #8914326 -
Flags: review?(spohl.mozilla.bugs)
Updated•7 years ago
|
Attachment #8914326 -
Flags: review?(spohl.mozilla.bugs) → review?(dtownsend)
Assignee | ||
Updated•7 years ago
|
Attachment #8914326 -
Flags: review?(dtownsend) → review?(mh+mozilla)
Assignee | ||
Comment 8•7 years ago
|
||
Mossop told me that we need a build peer here.
Mike, this will land with bug 1378834, bug 1404823 and bug 1399457 at the same time.
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8914326 [details]
Bug 1404796 - Add space in the Display name of Firefox {Nightly, Developer Edition}
https://reviewboard.mozilla.org/r/185610/#review212046
Attachment #8914326 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 11•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/42339ef2360cf8875c195b1b20e133eddf6ee499
Bug 1404796 - Add space in the Display name of Firefox {Nightly, Developer Edition} r=glandium
Comment 12•7 years ago
|
||
Backed out for build bustages on ../build/compare-mozconfig/compare-mozconfigs-wrapper.py::TestCompareMozconfigs::test_compare_mozconfigs
Treeheder link with the push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8d8bb8542b3d23f2b590f9c2b1cb9215219527df&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception
Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/d94f6fad91e42260b0a93f097bb38d93aea41970
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=152720370&repo=mozilla-inbound&lineNumber=30264
Flags: needinfo?(sledru)
Assignee | ||
Comment 13•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d71acb742e1106fa204287ec3ac1d45aba806d70
Bug 1404796 - Add space in the Display name of Firefox {Nightly, Developer Edition} r=glandium
Comment 14•7 years ago
|
||
Backed out changeset d71acb742e11 (bug 1404796) for failing Browser-chrome on toolkit/xre/test/browser_checkdllblockliststate.js on a CLOSED TREE
https://treeherder.mozilla.org/logviewer.html#?job_id=152893594&repo=mozilla-inbound&lineNumber=6086
https://hg.mozilla.org/integration/mozilla-inbound/rev/31fe03806a7af74d04b08c7650fa74755071268a
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=40eb00c21e7c776d4781c28e88a9b0917b4396ce&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=152893594
Comment 15•7 years ago
|
||
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/86268d3881a5
Add space in the Display name of Firefox {Nightly, Developer Edition} r=glandium
Comment 16•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(sledru)
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•