Matthew Blanchard Reporter
	Description • 23 years ago

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.9+) Gecko/20020329
BuildID:    20020329

When a block element appears immediately after <LI> in RTL lists, the bullet (or
the number) of the item appears on the left, not on the right.

Reproducible: Always

Steps to Reproduce:

<ul dir="rtl">
<li>one
<li>two
<li><div>three</div>
<li>four
</ul>

The block element must be the first node inside the LI element for this bug to
occur. If there's some inline element or some text preceding the block element,
the bullet (or the number) appears correctly -- on the right.

	Boris Zbarsky [:bzbarsky]
	Comment 2 • 23 years ago

Confirmed.

	Simon Montagu :smontagu
	Comment 3 • 23 years ago

*** Bug 141009 has been marked as a duplicate of this bug. ***

	Matthew Blanchard Reporter
	Comment 4 • 22 years ago

BTW, I think it is important to fix this bug because Microsoft's Outlook Express
adds DIVs to lists, and consequently Messenger users that receive HTML email
from OE users will sometimes have the bullets/numbers on the left.

	Simon Montagu :smontagu
	Comment 5 • 22 years ago

*** Bug 204232 has been marked as a duplicate of this bug. ***

	Lina Kemmel
	Comment 7 • 22 years ago

Disnatce a marker from the right border edge of the associated principal box.
The fix is supposed to cover also bug 202471 and, partly, bug 206089.

	Pascal Chevrel:pascalc (PTO until August 21)
	Comment 8 • 22 years ago

*** Bug 208248 has been marked as a duplicate of this bug. ***

	Pascal Chevrel:pascalc (PTO until August 21)
	Comment 9 • 22 years ago

isn't bug 74880 a consequence of this bug ?

	Lina Kemmel
	Comment 10 • 22 years ago

In my opinion, bug 208248 is a duplicate of bug 74880 (and not of the current
one), and both of them (bug 208248 and bug 74880) are unrelated to the current bug.

	Lina Kemmel
	Comment 11 • 22 years ago

The proposed fix (attachment 124734 [details] [diff] [review]) is based on CSS2 spec. CSS3 is going to
introduce a change from CSS2: "Markers are now aligned relative to the line box
edge, rather than the border edge". How we proceed?

	Asaf Romano (gone)
	Comment 12 • 21 years ago

Seams to be fixed from 1.7a :-)

	Asaf Romano (gone)
	Comment 13 • 21 years ago

(In reply to comment #12)
> Seams to be fixed from 1.7a :-)

Oh sorry this hasn't benn fixed at all. I confused with bug 198869

	Prognathous
	Comment 14 • 20 years ago

Lina Kemmel, could you please update your patch and ask for reviews? It's a
shame that your hard work gets bit-rotted instead of checked in (Bug 195909
comes to mind).

Thanks,

Prog.

	Lina Kemmel
	Comment 15 • 20 years ago

In addition to said in comment #7, the patch removes some obsolete (after
D.Baron's fixes for bug 74880) code, and contains css changes (replacing
marker's 'margin-right' with '-moz-margin-end').

	Asaf Romano (gone)
	Comment 16 • 20 years ago

(In reply to comment #15)
> Created an attachment (id=150136)
> up-to-date patch
> 
> In addition to said in comment #7, the patch removes some obsolete (after
> D.Baron's fixes for bug 74880) code, and contains css changes (replacing
> marker's 'margin-right' with '-moz-margin-end').
> 

Lina, can you please ask for review?

	Simon Montagu :smontagu
	Comment 17 • 20 years ago

Comment on attachment 150136 [details] [diff] [review]
up-to-date patch

r=smontagu

	Asaf Romano (gone)
	Comment 18 • 20 years ago

(In reply to comment #17)
> (From update of attachment 150136 [details] [diff] [review])
> r=smontagu
> 

Now can someone chek it in? :-)

	Prognathous
	Comment 19 • 20 years ago

Comment on attachment 150136 [details] [diff] [review]
up-to-date patch

(In reply to comment #18)
> Now can someone chek it in? :-)

An sr= is needed first.

Prog.

	David Baron :dbaron:
	Comment 20 • 20 years ago

Comment on attachment 150136 [details] [diff] [review]
up-to-date patch

I don't understand the nsLineLayout changes, but sr=dbaron.

	Simon Montagu :smontagu
	Comment 21 • 20 years ago

Patch checked in. Thank you, Lina!

	Lina Kemmel
	Comment 22 • 20 years ago

Simon, David, thanks a lot for reviewing and checking in the changes.

(In reply to comment #20)
nsLineLayout changes:
- remove unnecessary adjustment of widths by |aLineBounds.x|,
- in visual RTL, reposition the frames also if |dx == 0|,
- do not adjust a bullet, since |nsBlockFrame::ReflowBullet| already did the 
job.

----------------
One question please:

Should aligning of a list item horizontally affect the outside marker?

E.g. is a LTR LI with various alignments supposed to be displayed as:
(|*| stays for the marker)

-----------------------------------------------
|*| a left-aligned item                        |
-----------------------------------------------

-----------------------------------------------
|*|               a centered item              |
-----------------------------------------------

-----------------------------------------------
|*|                       a right-aligned item |
-----------------------------------------------

 - or should it adhere to the content position?)

(I think content aligning shouldn't affect both the principal block box and the 
marker box dimensions or position, i.e. the marker should not be repositioned.)

Depending on your answer, a LTR or RTL LI will need a small fix (but I'll file 
a new bug for it).

	Asaf Romano (gone)
	Comment 23 • 20 years ago

any chance to checkk this into aviary too?

	Nir Soffer
	Comment 24 • 20 years ago

Test also p element, valid code and link to W3c Validator. This should be the
standard on all testcases.

	Simon Montagu :smontagu
	Comment 25 • 20 years ago

*** Bug 252499 has been marked as a duplicate of this bug. ***

	Simon Montagu :smontagu
	Comment 26 • 20 years ago

*** Bug 253717 has been marked as a duplicate of this bug. ***

	Simon Montagu :smontagu
	Comment 27 • 20 years ago

Comment on attachment 150136 [details] [diff] [review]
up-to-date patch

Asking for approval-aviary, since 2 dupes have recently been filed against
firefox 0.9.1

	Simon Montagu :smontagu
	Comment 28 • 20 years ago

Comment on attachment 150136 [details] [diff] [review]
up-to-date patch

Asking for approval-aviary, since 2 dupes have recently been filed against
firefox.

	David Baron :dbaron:
	Comment 29 • 20 years ago

(In reply to comment #22)
> One question please:
> 
> Should aligning of a list item horizontally affect the outside marker?

According to CSS2, no.  (Assuming aligning refers to 'text-align' and not to
'auto' margins, in which case the answer is definitely yes.)  According to
CSS2.1, it's undefined.  According to css3-lists (draft), it's no, but that
might change.

	Mike Kaply [:mkaply] Assignee
	Comment 30 • 20 years ago

Comment on attachment 150136 [details] [diff] [review]
up-to-date patch

a=mkaply

Let's put it on 1.7 too

	Nir Soffer
	Comment 31 • 20 years ago

(In reply to comment #30)
> Let's put it on 1.7 too
This bug still show in 1.8a2, but fixed nightly build 2004080408

I checked only on Mac OS X 10.3.3

	Uri Bernstein (Google)
	Comment 32 • 20 years ago

(In reply to comment #28)
> Asking for approval-aviary, since 2 dupes have recently been filed against
> firefox.

As the (not so) proud submitter of one of those dupes, may I ask: your request
to check in to aviary was approved a few days ago (together with approving 1.7),
yet as far as I can tell, you checked the fix in to 1.7 but not to the Aviary
branch.
Is there a reason for this, or is it just an oversight? (or did I just read the
CVS logs incorrectly? - I'm still learning my way around here).  

	Simon Montagu :smontagu
	Comment 33 • 20 years ago

It was an oversight. Thanks for the reminder.

	Asaf Romano (gone)
	Comment 34 • 20 years ago

verified

	David Baron :dbaron:
	Comment 35 • 20 years ago

This caused regression bug 259683.  I'm likely to back a small part of the patch
out to fix the regression.  What do I need to test?

	(no longer active)
	Comment 36 • 17 years ago

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).