Closed Bug 1407637 Opened 7 years ago Closed 7 years ago

Fennec mark release as shipped in-tree task

Categories

(Release Engineering :: Release Automation: Other, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1406517 +++ Let's build a bbb task in-tree for marking Fennec release as shipped. This will allow for firefox "mark release as shipped" as well.
Attached patch release-mark-as-shipped.diff (obsolete) (deleted) — Splinter Review
Probably this should just work...
Attachment #8917405 - Flags: feedback?(aki)
Comment on attachment 8917405 [details] [diff] [review] release-mark-as-shipped.diff LGTM. I think we need to add a dependency on push-to-releases once that's a task. We probably need to add it to the publish_fennec target_tasks_method as well. On this line [1] we probably need a code block like if task.task['payload'].get('properties', {}).get('product') == 'fennec': if task.kind in ('release-mark-as-shipped', ): return True [1] https://hg.mozilla.org/projects/maple/file/tip/taskcluster/taskgraph/target_tasks.py#l410
Attachment #8917405 - Flags: feedback?(aki) → feedback+
We should also figure out how to switch between prod/dev ship-it URLs properly
Looks like you figured this out, yay! We have logic in https://hg.mozilla.org/projects/maple/file/tip/taskcluster/taskgraph/util/scriptworker.py that does similar things for scopes; Callek suggested we move that to the kind.yml files, and I'm starting to agree. That's probably a separate non-blocker bug.
Attached patch bug1407637-mark-as-shipped.diff (deleted) — Splinter Review
* added a TODO to add deps * added to target_tasks_publish_fennec()
Attachment #8917405 - Attachment is obsolete: true
Blocks: 1413299
No longer blocks: 1413299
This is on central now.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: