Closed
Bug 1407817
Opened 7 years ago
Closed 7 years ago
enable fennec relpro on maple
Categories
(Release Engineering :: Release Automation: Other, enhancement)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mozilla, Assigned: mozilla)
References
Details
Attachments
(5 files, 1 obsolete file)
(deleted),
patch
|
rail
:
feedback+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
rail
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mtabara
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mtabara
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
garbas
:
feedback+
|
Details | Diff | Splinter Review |
We enabled this for devedition + firefox, but not fennec.
We're missing a bunch of files to do so.
Assignee | ||
Comment 1•7 years ago
|
||
Not sure about the depend signing cert stuff, also need to make sure these files exist in-tree.
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8917599 -
Flags: feedback?(rail)
Assignee | ||
Comment 3•7 years ago
|
||
This passes travis: https://travis-ci.org/escapewindow/build-buildbot-configs/builds/286768813?utm_source=github_status&utm_medium=notification
Do you know what we should do about the depend signature stuff? Will it matter?
Essentially, right now maple is signing with the dep key. If we can continue making things work with the dep key, we are that much closer to staging releases on try. If that's too hard or time consuming, we can switch to release-signing and leave staging-releases-on-try for later.
Attachment #8917594 -
Attachment is obsolete: true
Attachment #8917601 -
Flags: review?(rail)
Comment 4•7 years ago
|
||
Comment on attachment 8917601 [details] [diff] [review]
bb-c.diff
Review of attachment 8917601 [details] [diff] [review]:
-----------------------------------------------------------------
I don't think we rely on any signing stuff in Fennec release automation.
Attachment #8917601 -
Flags: review?(rail) → review+
Comment 5•7 years ago
|
||
Comment on attachment 8917599 [details] [diff] [review]
maple-configs.diff
Review of attachment 8917599 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #8917599 -
Flags: feedback?(rail) → feedback+
Assignee | ||
Comment 6•7 years ago
|
||
Based off https://github.com/mozilla-releng/beetmoverscript/blob/master/requirements-prod.txt + beetmoverscript 2.0.0. This patch works on beetmover-dev1 atm.
Sorry about the whitespace diff that makes every line change.
Attachment #8921240 -
Flags: review?(mtabara)
Updated•7 years ago
|
Attachment #8921240 -
Flags: review?(mtabara) → review+
Assignee | ||
Comment 7•7 years ago
|
||
This, along with a version bump to land https://github.com/mozilla-releng/beetmoverscript/pull/89 , should get fennec beetmover candidates green again :)
Attachment #8921591 -
Flags: review?(mtabara)
Comment 8•7 years ago
|
||
Comment on attachment 8921591 [details] [diff] [review]
fix_beetmover2.diff
+ commented addressed in PR.
Attachment #8921591 -
Flags: review?(mtabara) → review+
Assignee | ||
Comment 9•7 years ago
|
||
Rail - we have next_version defined in payload properties on some non-version bumping tasks.
Do you know if that will break?
Flags: needinfo?(rail)
Comment 10•7 years ago
|
||
(In reply to Aki Sasaki [:aki] from comment #9)
> Rail - we have next_version defined in payload properties on some
> non-version bumping tasks.
> Do you know if that will break?
Nope, none of them use that property. All good.
Flags: needinfo?(rail)
Assignee | ||
Comment 11•7 years ago
|
||
:garbas , we're both new to this, but does this look sane?
When I diff an unpatched-maple and a patched-maple's output with
./mach taskgraph target-graph -p /src/gecko/params/maple-publish-fennec.yml --json
I get
4197c4197,4199
< "dependencies": {},
---
> "dependencies": {
> "fennec-push-to-cdns": "fennec-push-to-cdns"
> },
And when I run
./mach taskgraph optimized -p /src/gecko/params/maple-publish-fennec.yml --json
I actually see the taskId of the beetmover-cdns task populated in the version bump task dependencies. So I'm pretty sure this works.
Attachment #8922671 -
Flags: feedback?(rgarbas)
Comment 12•7 years ago
|
||
Comment on attachment 8922671 [details] [diff] [review]
dependencies
:aki Sorry I only noticed today that you pinged me on friday. it always looks strange to me that we have to create new transforms. i would assume dependency handling would be already solved by task transform, since it is such a basic requirement. other then that i think the change looks good.
Attachment #8922671 -
Flags: feedback?(rgarbas) → feedback+
Assignee | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•