Closed Bug 1414126 Opened 7 years ago Closed 7 years ago

Intermittent TEST-UNEXPECTED-TIMEOUT | browser/base/content/test/performance/browser_urlbar_search_reflows.js | application timed out after 330 seconds with no output - on debug builds

Categories

(Firefox :: General, defect, P5)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: florian)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

disable on Linux debug and Windows debug
(deleted), patch
mconley
: review+
Details | Diff | Splinter Review
The failures here are relatively frequent (2 out of 16 runs in https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d07ca0d2c6619ad03c238dc3401a291e50bf5ae) and I think running this test on debug builds has little value, so I propose we disable the test on Linux debug and Windows debug (we've no record of a Mac debug failure, so I'm not disabling it there, but I would be open to disabling on debug builds completely if you think that's preferable).
Attachment #8937969 - Flags: review?(mconley)
Assignee: nobody → florian
Status: NEW → ASSIGNED
Comment on attachment 8937969 [details] [diff] [review] disable on Linux debug and Windows debug Review of attachment 8937969 [details] [diff] [review]: ----------------------------------------------------------------- WFM, thanks! ::: browser/base/content/test/performance/browser.ini @@ +27,5 @@ > [browser_toolbariconcolor_restyles.js] > [browser_urlbar_keyed_search_reflows.js] > skip-if = (os == 'linux') || (os == 'win' && debug) # Disabled on Linux and Windows debug due to perma failures. Bug 1392320. > [browser_urlbar_search_reflows.js] > +skip-if = debug && (os == 'linux' || os == 'win') # Disabled on Linux and Windows debug due to intermittent timeouts. Bug 1414126. I'm fine with this, but would you mind filing a new bug to investigate and re-enable the test, and refer to that here instead?
Attachment #8937969 - Flags: review?(mconley) → review+
Pushed by florian@queze.net: https://hg.mozilla.org/integration/mozilla-inbound/rev/3ac6f5c8accc disable browser_urlbar_search_reflows.js on Linux debug and Windows debug due to intermittent timeouts, r=mconley.
(In reply to Mike Conley (:mconley) (:⚙️) - Backlogged on reviews and needinfos from comment #10) > would you mind filing a new bug to investigate and > re-enable the test, and refer to that here instead? It's not really a bug of the test, it's more that we do lots of reflows here, and it's taking ages. The test is very slow when it doesn't timeout. It's slow even on opt builds. The worst offender in terms of reflows here is bug 1356532. I'll add a note there.
https://hg.mozilla.org/mozilla-central/rev/3ac6f5c8accc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Summary: Intermittent TEST-UNEXPECTED-TIMEOUT | browser/base/content/test/performance/browser_urlbar_search_reflows.js | application timed out after 330 seconds with no output → Intermittent TEST-UNEXPECTED-TIMEOUT | browser/base/content/test/performance/browser_urlbar_search_reflows.js | application timed out after 330 seconds with no output - on debug builds
I was curious to see why this test takes so long so I put the profiler at it, here's the result: https://perfht.ml/2z9Ot6M Nothing outstanding, except the many reflows we already know about.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: