Closed Bug 1414345 Opened 7 years ago Closed 6 years ago

Should insert "Frame construction" markers for nsCSSFrameConstructor::ContentAppended and friends

Categories

(Core :: Gecko Profiler, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox58 --- wontfix
firefox59 --- wontfix
firefox63 --- fixed

People

(Reporter: mstange, Assigned: canova)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The style flush marker won't capture this, we need an extra marker.
Priority: -- → P3
Blocks: 1437157
Assignee: nobody → canaltinova
Status: NEW → ASSIGNED
This bug is related to markers but dependent bug is about label frames. Just to be sure, we are talking about the markers, right?
Oh oops, I was confused. I thought this bug was about the label frame, but you're right, it's about markers. I suppose we could add both of them at the same time?
I added both of them. It will require a small PR on the perf.html side for the new markers. Preparing it now.
Comment on attachment 8995203 [details] Bug 1414345 - Part 1: Add 'Frame Construction' markers to all frame construction paths https://reviewboard.mozilla.org/r/259698/#review267066
Attachment #8995203 - Flags: review?(mstange) → review+
Comment on attachment 8995204 [details] Bug 1414345 - Part 2: Add AutoProfilerLabels for all Frame Construction paths https://reviewboard.mozilla.org/r/259700/#review267068
Attachment #8995204 - Flags: review?(mstange) → review+
Pushed by canaltinova@gmail.com: https://hg.mozilla.org/integration/autoland/rev/45a0c8664fcf Part 1: Add 'Frame Construction' markers to all frame construction paths r=mstange https://hg.mozilla.org/integration/autoland/rev/147d99782475 Part 2: Add AutoProfilerLabels for all Frame Construction paths r=mstange
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: