Closed
Bug 1414345
Opened 7 years ago
Closed 6 years ago
Should insert "Frame construction" markers for nsCSSFrameConstructor::ContentAppended and friends
Categories
(Core :: Gecko Profiler, enhancement, P3)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla63
People
(Reporter: mstange, Assigned: canova)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
The style flush marker won't capture this, we need an extra marker.
|
||
Comment 1•7 years ago
|
||
status-firefox59:
--- → ?
|
||
Updated•6 years ago
|
Priority: -- → P3
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → canaltinova
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
This bug is related to markers but dependent bug is about label frames. Just to be sure, we are talking about the markers, right?
|
Reporter | |
Comment 3•6 years ago
|
||
Oh oops, I was confused. I thought this bug was about the label frame, but you're right, it's about markers. I suppose we could add both of them at the same time?
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 6•6 years ago
|
||
I added both of them. It will require a small PR on the perf.html side for the new markers. Preparing it now.
|
|
Assignee | |
Comment 7•6 years ago
|
||
Perf.html PR: https://github.com/devtools-html/perf.html/pull/1159
This profile includes both label frames and markers: https://deploy-preview-1159--perf-html.netlify.com/public/a0200c22a1f9058c0000ee4f343c718cfd414d17/calltree/?hiddenThreads=2&range=0.6295_1.6208~0.8550_1.5076&search=nsCSSFrameConstructor&thread=5&threadOrder=0-2-3-4-5-1&v=3
|
|
Reporter | |
Comment 8•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8995203 [details]
Bug 1414345 - Part 1: Add 'Frame Construction' markers to all frame construction paths
https://reviewboard.mozilla.org/r/259698/#review267066
Attachment #8995203 -
Flags: review?(mstange) → review+
|
|
Reporter | |
Comment 9•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8995204 [details]
Bug 1414345 - Part 2: Add AutoProfilerLabels for all Frame Construction paths
https://reviewboard.mozilla.org/r/259700/#review267068
Attachment #8995204 -
Flags: review?(mstange) → review+
|
||
Comment 10•6 years ago
|
||
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/45a0c8664fcf
Part 1: Add 'Frame Construction' markers to all frame construction paths r=mstange
https://hg.mozilla.org/integration/autoland/rev/147d99782475
Part 2: Add AutoProfilerLabels for all Frame Construction paths r=mstange
|
||
Comment 11•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/45a0c8664fcf
https://hg.mozilla.org/mozilla-central/rev/147d99782475
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•