Closed Bug 1415212 Opened 7 years ago Closed 7 years ago

release-runner3 should pass partials to action task input

Categories

(Release Engineering :: Release Automation: Other, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(2 files)

We need to pass partial release information from ship-it (already there) to the corresponding action task input. Rok already has some patches to specify those data maple.
Comment on attachment 8925984 [details] Bug 1415212 - release-runner3 should pass partials to action task input https://reviewboard.mozilla.org/r/197210/#review202342 1) Aha, I saw this coming when I dug again to understand how actions work. Was wondering why we didn't do this in the first round but since we tackled Fennec first, there was no need for partials. Makes sense 2) More of a wild guess but shouldn't we add the info under https://hg.mozilla.org/build/tools/file/tip/buildfarm/release/trigger_action.py#l53 as well? For publishing firefox we'd need all the info from first promote firefox TaskId to be able to rebuild/reuse stuff from first graph? ::: buildfarm/release/release-runner3.py:53 (Diff revision 1) > > > +def assign_and_check_partial_updates(release_runner, release, releases_config): > + release['partial_updates'] = get_partials( > + release_runner, release['partials'], release['product']) > + PartialsSanitizer(**release).run() No more release-channels, goodbye "if else if"!
Attachment #8925984 - Flags: review?(mtabara) → review+
Comment on attachment 8925983 [details] Bug 1415212 - release-runner3 should pass partials to action task input https://reviewboard.mozilla.org/r/197214/#review202344 Ah, we missed doing the cleanup in the first place. Good catch!
Attachment #8925983 - Flags: review?(mtabara) → review+
(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #3) > 2) More of a wild guess but shouldn't we add the info under > https://hg.mozilla.org/build/tools/file/tip/buildfarm/release/trigger_action. > py#l53 as well? For publishing firefox we'd need all the info from first > promote firefox TaskId to be able to rebuild/reuse stuff from first graph? > We don't have those action flavors yet. I'll update that script when we have some concrete examples.
Attachment #8925984 - Flags: checked-in+
Attachment #8925983 - Flags: checked-in+
The puppet patch is not critical to deploy, we just skip the missing checks.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: