Closed
Bug 1415407
Opened 7 years ago
Closed 7 years ago
Add webrender support for filters (hue-rotate, opacity, saturate)
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox57 | --- | unaffected |
firefox58 | --- | unaffected |
firefox59 | --- | fixed |
People
(Reporter: ethlin, Assigned: ethlin)
References
(Blocks 1 open bug)
Details
(Whiteboard: [wr-mvp])
Attachments
(2 files)
Webrender already implements hue-rotate, opacity and saturate. So I just need to wire them up for webrender. I know there might be some webrender work for fixing the reftest failures.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8926228 [details] Bug 1415407 - Add webrender support for filters (hue-rotate, opacity, saturate). https://reviewboard.mozilla.org/r/197490/#review202698 C/C++ static analysis found 0 defects in this patch. You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8926228 [details] Bug 1415407 - Add webrender support for filters (hue-rotate, opacity, saturate). https://reviewboard.mozilla.org/r/197490/#review202878
Attachment #8926228 -
Flags: review?(bugmail) → review+
Updated•7 years ago
|
Whiteboard: [wr-mvp] [triage]
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [wr-mvp] [triage] → [wr-mvp]
Can this wait until January?
Assignee: ethlin → nobody
Blocks: stage-wr-trains
Status: ASSIGNED → NEW
status-firefox57:
--- → unaffected
status-firefox58:
--- → unaffected
Flags: needinfo?(ethlin)
Priority: P1 → P3
Whiteboard: [wr-mvp] → [wr-mvp][wr-reserve-candidate]
What about the "I know there might be some webrender work for fixing the reftest failures."? Is this patch the end of it? If it is, great.
Assignee | ||
Comment 8•7 years ago
|
||
The wr change seems to be simple. I just sent a PR: https://github.com/servo/webrender/pull/2017. If there is no other concern, I hope we can land this patch.
Flags: needinfo?(ethlin)
If we have everything working, absolutely we should land it.
Updated•7 years ago
|
Assignee: nobody → ethlin
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [wr-mvp][wr-reserve-candidate] → [wr-mvp]
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 12•7 years ago
|
||
It's still waiting for the WR update. I update the annotations based on this try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=521dedec24e72e5766ffeb8f02dccb459e29fa27&selectedJob=144532714.
Comment 14•7 years ago
|
||
(In reply to Ethan Lin[:ethlin] from comment #12) > It's still waiting for the WR update. I update the annotations based on this > try push: > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=521dedec24e72e5766ffeb8f02dccb459e29fa27&selectedJob=1 > 44532714. I don't think this is the right try push. I couldn't find the one you meant so I did a new one based on tip and with your first patch applied: https://treeherder.mozilla.org/#/jobs?repo=try&revision=780645b476da4ce679529e435029be6d4b04c785
Comment 15•7 years ago
|
||
mozreview-review |
Comment on attachment 8928417 [details] Bug 1415407 - Update annotations for related tests. https://reviewboard.mozilla.org/r/199642/#review204864 Based on the try push I did, there are three more failures than what you annotated: hue-rotate-grad.html, hue-rotate-rad.html, and hue-rotate-turn.html. The first one might be fuzzy, but the other two are the wrong color and so probably failures.
Attachment #8928417 -
Flags: review?(bugmail) → review-
Assignee | ||
Comment 16•7 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #15) > Comment on attachment 8928417 [details] > Bug 1415407 - Update annotations for related test. > > https://reviewboard.mozilla.org/r/199642/#review204864 > > Based on the try push I did, there are three more failures than what you > annotated: hue-rotate-grad.html, hue-rotate-rad.html, and > hue-rotate-turn.html. The first one might be fuzzy, but the other two are > the wrong color and so probably failures. Sorry, the try push should be this one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca4753a3913013cdc80bd5cbba81f2213ce9ae51. The first patch has a small bug. I'll update the patch and send a try push again.
Updated•7 years ago
|
Blocks: motionmark
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 19•7 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8fcceb9972af40fb85b656f1d57383e86846322
Comment 20•7 years ago
|
||
mozreview-review |
Comment on attachment 8928417 [details] Bug 1415407 - Update annotations for related tests. https://reviewboard.mozilla.org/r/199642/#review204918
Attachment #8928417 -
Flags: review?(bugmail) → review+
Comment 22•7 years ago
|
||
Pushed by ethlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/60ed7a647f38 Add webrender support for filters (hue-rotate, opacity, saturate). r=kats https://hg.mozilla.org/integration/autoland/rev/b73b29bfcbde Update annotations for related tests. r=kats
Assignee | ||
Comment 23•7 years ago
|
||
(In reply to Markus Stange [:mstange] from comment #21) > Does this fix bug 1408116? No, this PR[1] should fix bug 1408116. [1] https://github.com/servo/webrender/pull/2048
Flags: needinfo?(ethlin)
Comment 24•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/60ed7a647f38 https://hg.mozilla.org/mozilla-central/rev/b73b29bfcbde
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•