Closed
Bug 1416466
Opened 7 years ago
Closed 7 years ago
Wait for the next event tick before resolving Promise for onload event in tests in security/manager/ssl/tests/mochitest/browser/, for bug 1193394
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a256f95712e8844d888ec18891822e949bc85c6d&selectedJob=143961944
> FAIL | security/manager/ssl/tests/mochitest/browser/browser_clientAuth_ui.js | Actual and expected hostname and port should be equal - "" == "Test Hostname:123"
those failure in security/manager/ssl/tests/mochitest/browser/ comes from the issue that onload event listener resolves the promise too early.
the test expects all things related to the load event is performed before the promise resolution handler gets called.
so, it should wait for the next event tick before resolving the promise.
Assignee | ||
Comment 1•7 years ago
|
||
delayed the promise resolution for load event to make sure the page really gets loaded.
Attachment #8929341 -
Flags: review?(dtownsend)
Updated•7 years ago
|
Attachment #8929341 -
Flags: review?(dtownsend) → review+
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c69914a66203
Wait for the next event tick before resolving Promise for onload event in tests in security/manager/ssl/tests/mochitest/browser/. r=mossop
Assignee | ||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c69914a662039fc3e359f74ed1c9ba58fcef6306
Bug 1416466 - Wait for the next event tick before resolving Promise for onload event in tests in security/manager/ssl/tests/mochitest/browser/. r=mossop
Comment 4•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in
before you can comment on or make changes to this bug.
Description
•