Closed
Bug 1414180
Opened 7 years ago
Closed 7 years ago
Fix failed browser-chrome tests which relies on non-comformant Promise handling
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: bevis, Unassigned)
References
Details
This is a meta bug for oranges browser-chrome tests captured by the try result in bug 1193394 comment 48.
In bug 1193394, we'd like to make the promise callback be executed at correct check-point right after an event handler/js callback is returned instead of at the end of a task to meet the requirement in HTML spec.
We saw lots of orange factors in bc(1,2,3,4,5,6,7,8,9,10,13,14,15,16) which need further breaking down to figure out the solution.
Reporter | ||
Comment 1•7 years ago
|
||
Updated try result on all platforms is available now in bug 1193394 comment 58.
The updated patches are attached as well in that bug.
Comment 2•7 years ago
|
||
testing some more fixes.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=06a1ff1697e9069fd4821b40040a530bfd25c1d5
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e11e5839c8a8f5e1b1cd8f2fc514c5c931771c24
I'll file bugs later.
Comment 3•7 years ago
|
||
to be clear, https://treeherder.mozilla.org/#/jobs?repo=try&revision=e11e5839c8a8f5e1b1cd8f2fc514c5c931771c24 is the test with bug 1193394 patch.
Comment 4•7 years ago
|
||
Comment 5•7 years ago
|
||
here's remaining failures, mostly intermittent :/
[before]
browser/modules/test/browser/browser_urlBar_zoom.js
browser/base/content/test/general/browser_ctrlTab.js
layout/xul/test/browser_bug703210.js ?
[after]
browser/base/content/test/general/browser_ctrlTab.js
browser/base/content/test/general/browser_trackingUI_5.js
browser/components/places/tests/browser/browser_check_correct_controllers.js
browser/modules/test/browser/browser_urlBar_zoom.js
Comment 6•7 years ago
|
||
before bug 1193394: https://treeherder.mozilla.org/#/jobs?repo=try&revision=519d57f9aab49202b0053e9471a85c4ca69d993d
after bug 1193394: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5b3bbfdbc949f84a7f2606e8b38422ebfc081d0
investigating browser/base/content/test/general/browser_ctrlTab.js, that fails only on try
Comment 7•7 years ago
|
||
there are several tests that are *not* failing, but resolves promise inside event handler.
I'm wondering if it's better fixing them as well...
(some of them might become intermittent, but not sure how many of them...)
Comment 8•7 years ago
|
||
(In reply to Tooru Fujisawa [:arai] from comment #6)
> investigating browser/base/content/test/general/browser_ctrlTab.js, that
> fails only on try
turns out that.... mouse cursor is accidentally there :P
Comment 9•7 years ago
|
||
Comment 10•7 years ago
|
||
checking the remaining failure
https://treeherder.mozilla.org/#/jobs?repo=try&revision=17fca1f2db86843ce54c307cbf4fefd7f6b3936f&group_state=expanded
Comment 11•7 years ago
|
||
looks like there are some more non-linux issues :P
Comment 12•7 years ago
|
||
here's list of possibly not-pre-existing failure.
I'll file them later
[browser/base/content/test/general/browser_tabfocus.js]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=17fca1f2db86843ce54c307cbf4fefd7f6b3936f&group_state=expanded&selectedJob=151166436
> TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_tabfocus.js | Test timed out -
> TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_tabfocus.js | Found a tab after previous test timed out: data:text/html,%3Chtml%20id%3D%27html2%27%3E%3Cbody%20id%3D%27body2%27%3E%3Cbutton%20id%3D%27button2%27%3ETab%202%3C/button%3E%3C/body%3E%3C/html%3E -
> TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_tabfocus.js | Found a tab after previous test timed out: data:text/html,%3Chtml%20id%3D%27html3%27%3E%3Cbody%20id%3D%27body3%27%3E%3Cbutton%20id%3D%27button3%27%3ETab%203%3C/button%3E%3C/body%3E%3C/html%3E -
[browser/base/content/test/performance/browser_windowopen_reflows.js]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=17fca1f2db86843ce54c307cbf4fefd7f6b3936f&group_state=expanded&selectedJob=151174922
> TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_windowopen_reflows.js | Unused expected reflow: [
> "select@chrome://global/content/bindings/textbox.xml",
> "focusAndSelectUrlBar@chrome://browser/content/browser.js"
> ]
> This reflow was supposed to be hit 1 more time(s).
> This is probably a good thing - just remove it from the expected list. - false == true - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/performance/head.js :: withReflowObserver :: line 149
> Stack trace:
> chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:withReflowObserver:149
[browser/base/content/test/tabPrompts/browser_openPromptInBackgroundTab.js]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=17fca1f2db86843ce54c307cbf4fefd7f6b3936f&group_state=expanded&selectedJob=151164059
> TEST-UNEXPECTED-FAIL | browser/base/content/test/tabPrompts/browser_openPromptInBackgroundTab.js | application terminated with exit code 1
> ...
> PROCESS-CRASH | browser/base/content/test/tabPrompts/browser_openPromptInBackgroundTab.js | application crashed [@ MOZ_CrashOOL]
[browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=17fca1f2db86843ce54c307cbf4fefd7f6b3936f&group_state=expanded&selectedJob=151164062
> TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js | Test timed out -
> TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js | Uncaught exception received from previously timed out test - at chrome://mochitests/content/browser/browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js:88 - TypeError: EventUtils.synthesizeMouseAtCenter is not a function
> Stack trace:
> disabled_button_in_panel@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js:88:3
> Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1065:21
> Tester_execTest@chrome://mochikit/content/browser-test.js:1056:9
> Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:956:9
> SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
[toolkit/components/printing/tests/browser_preview_switch_print_selected.js]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=17fca1f2db86843ce54c307cbf4fefd7f6b3936f&group_state=expanded&selectedJob=151166712
> TEST-UNEXPECTED-FAIL | toolkit/components/printing/tests/browser_preview_switch_print_selected.js | uncaught exception - Error: Assertion failure at assert@chrome://browser/content/tabbrowser.xml:4631:25
Comment 13•7 years ago
|
||
browser_tabfocus.js should be fixed in bug 1421113.
browser_windowopen_reflows.js seems to be related to bug 1380465.
Comment 14•7 years ago
|
||
browser_preview_switch_print_selected.js seems to be bug 1392226, unless the patch makes it more intermittent
Comment 15•7 years ago
|
||
browser/components/preferences/in-content/tests/browser_subdialogs.js and
browser/components/extensions/test/browser/test-oop-extensions/browser_ext_user_events.js
might be affected by the change, while there's known intermittent.
I'll investigate tomorrow.
Comment 16•7 years ago
|
||
all bugs are fixed :D
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•