Closed Bug 1416870 Opened 7 years ago Closed 7 years ago

Further improve perfherder's test data chooser for longer test names

Categories

(Tree Management :: Perfherder, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wlach, Assigned: wlach)

Details

Attachments

(2 files)

There are some small things we could do to improve the display of the test data chooser for very long test names e.g. "sccache requests_not_cacheable opt taskcluster-c4.4xlarge valgrind" 1. Use a smaller font size for the test input 2. Always use abbreviated mode for displaying the test, so we don't add a redundant "summary" title (we already do this for perfherder alerts). 3. Don't show an option twice if it is redundant (e.g. "asan asan").
Attachment #8927950 - Flags: review?(rwood)
Attachment #8927950 - Flags: review?(rwood) → review+
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/e54fcfcb307f7c7ba9c36246eed39b120eebbdd8 Bug 1416870 - Use a smaller font size for the test chooser https://github.com/mozilla/treeherder/commit/f957f49256c409fddf965facd3f2bbed5a558d83 Bug 1416870 - Remove duplicate options when calculating test name in test data chooser E.g. there is no need to show "asan asan"
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
I owe a beer or equivalent token of appreciation for this fix! I will conveniently be in Toronto the week of November 27.
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/983e9007e0e8f21b75e103da412a56ee0a08fd83 Revert "Bug 1416870 - Always use abbreviated mode for calculating performance test name" (#2960) This reverts commit aa270ca5d974fe2207304d6c9dcdd8b8cbf24005.
This caused a regression where the subtest link is not present on the compare view (pointed out by developers today). I have verified that a | git revert aa270ca5d974fe2207304d6c9dcdd8b8cbf24005 | solves the problem in local testing and have pushed that as a PR. I have also commented in the PR for this to indicate where I think the problem is: https://github.com/mozilla/treeherder/commit/aa270ca5d974fe2207304d6c9dcdd8b8cbf24005
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
:wlach, I know you are out today, so please look into this.
Flags: needinfo?(wlachance)
Confirmed. I have a fix, but am currently blocked on bug 1419777 so I can test it.
Flags: needinfo?(wlachance)
Comment on attachment 8932159 [details] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/2991 This updated patch addresses the issue that jmaher mentioned above.
Attachment #8932159 - Flags: review?(rwood)
Attachment #8932159 - Flags: review?(rwood) → review+
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/539941c9781b2c6913d99e58ee7a0ccdcaaba73d Bug 1416870 - Always use abbreviated mode for calculating performance test name (#2991) This means we no longer display tests as being a "summary" in the test chooser (you can generally figure that out by noticing that there is no subtest specified).
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: