Closed Bug 1417787 Opened 7 years ago Closed 7 years ago

about:healthreport (Health Report) main content is broken due to use of array comprehensions

Categories

(Firefox Health Report Graveyard :: Web: Health Report, defect, P1)

Product:
Firefox Health Report Graveyard
Component:
Web: Health Report
Version:
58 Branch
Type:
defect

Tracking

(firefox-esr52 unaffected, firefox57 unaffected, firefox58+ fixed, firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 + fixed
firefox59 --- fixed

People

(Reporter: MattN, Assigned: Dexter)

References

(
URL
)

Details

(Keywords: regression, Whiteboard: [measurement:client])

[Tracking Requested - why for this release]: about:healthreport is quite broken > SyntaxError: expected expression, got keyword 'for' fhr_v4.js:71:40 https://github.com/mozilla/fhr-jelly/blob/b6717cc2ed4671f7d16ea21683cd7bd40757a720/js/fhr_v4.js#L71-L72
Track 58+ as about:healthreport is broken. Hi Georg, Can you help shed some light here?
tracking-firefox58: ? → +
Flags: needinfo?(gfritzsche)
Array comprehensions are gone in 58, we need to change the code here.
Assignee: nobody → gfritzsche
Flags: needinfo?(gfritzsche)
Priority: -- → P1
Whiteboard: [measurement:client]
This should be on staging with the next automatic update: http://fhr-dev.allizom.org/dsb/v4/
Alessio, can you give this a test run in Fx 58 once it hits staging? After that we need to deploy this to production. We can clone bug 1335821 for that (i think that's the most recent).
Assignee: gfritzsche → alessio.placitelli
(In reply to Georg Fritzsche [:gfritzsche] [away Nov 24 - Dec 3] from comment #6) > Alessio, can you give this a test run in Fx 58 once it hits staging? I can confirm that this is correctly loading in today's Nightly, while the old page is broken.
Depends on: 1420839
I've also tested this in stage and everything looks good: the general layout, links functionality, all the pings are correctly displayed and their structure is correct.
Thanks Madalin. The new FHR was deployed and it's working.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
status-firefox58: affected → fixed
status-firefox59: affected → fixed
Target Milestone: --- → Firefox 59
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.