Closed Bug 1420319 Opened 7 years ago Closed 7 years ago

Wait for the next event tick in browser/components/extensions/test/browser/browser_ext_optionsPage_modals.js

Categories

(Firefox :: General, enhancement)

Product:
Firefox
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

Wait for the next event tick before resolving promise in browser_ext_optionsPage_modals.js.
(deleted), patch
jaws
: review+
Details | Diff | Splinter Review
browser/components/extensions/test/browser/browser_ext_optionsPage_modals.js > FAIL | browser/components/extensions/test/browser/browser_ext_optionsPage_modals.js | Expect a tab modal opened for the about addons tab - 0 == 1 The testcase should wait for the next event tick before resolving promise for DOMWillOpenModalDialog event.
the test should wait for the next event tick before resolving the promise inside DOMWillOpenModalDialog event handler, to avoid the remaining part of the testcase runs before the dialog gets opened, after the change in bug 1193394.
Attachment #8933508 - Flags: review?(jaws)
Attachment #8933508 - Flags: review?(jaws) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f60eb7eeb88b271a33af7caee4647a92c479aef Bug 1420319 - Wait for the next event tick before resolving promise in browser_ext_optionsPage_modals.js. r=jaws
https://hg.mozilla.org/mozilla-central/rev/0f60eb7eeb88
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: