Closed
Bug 1420941
Opened 7 years ago
Closed 7 years ago
Make it harder to forget to run Vagrant provision regularly
Categories
(Tree Management :: Treeherder, enhancement, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
We've had a few bugs filed /IRC debugging sessions over the months that turned out to be due to people's Vagrant environment not being up to date (ie `vagrant provision` not run recently; eg bug 1420918).
Sadly Vagrant doesn't have any in-built functionality for warning if provision hasn't been run recently, but perhaps we could make our own in the bash profile login script (or even just run provision automatically if > N days/weeks).
(It's worth noting this is another pain point that we wouldn't have if we were using Docker/Docker Compose - bug 1169263)
Assignee | ||
Comment 1•7 years ago
|
||
I've had a look into doing this, but the options aren't great - we should just do bug 1169263.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Assignee | ||
Comment 2•7 years ago
|
||
Joel hit this again today.
I had an idea - let's just update the docs to always say to use `vagrant up --provision` rather than just `vagrant up`. Whilst the former is redundant for new users, it's likely those returning after a gap will refer back to those docs and end up running provision without needing to remember to :-)
Assignee: nobody → emorley
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Comment 3•7 years ago
|
||
Comment 4•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/70e9cdc91d227bcf25fc0f38783728e892e7dfae
Bug 1420941 - Docs: Encourage users to run Vagrant provision (#3539)
The `--provision` flag is unnecessary for new instances, since Vagrant
runs `provision` as part of the initial `up` regardless. However by
including `--provision` in the suggested command, it will mean
returning contributors will re-run provision when they re-use the
same steps.
An alternative approach would be to mark the provision block in
`Vagrantfile` as `run: "always"`, however that would slow down the
`vagrant up` of core developers too (by 40s), with no way to opt-out.
Assignee | ||
Updated•7 years ago
|
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Component: Treeherder: Docs & Development → TreeHerder
You need to log in
before you can comment on or make changes to this bug.
Description
•