Closed Bug 1421097 Opened 7 years ago Closed 7 years ago

Require Rust 1.22

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

We can start requiring Rust 1.22 to build Firefox 59 starting 2017 December 7.
Not until we at least build with 1.22 on Windows.
Depends on: 1417268
Depends on: 1421100
We'll need Rust 1.22 for the webrender update which contains servo/webrender#2128. No pressure or anything but we would really like to get that in before the all-hands :) The specific problem is that 1.21 fails to properly handle [patch] replacements where we replace a crates.io crate with one from a git repo. Try push showing the failures is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=564675d02666501b448090a8c9076f24edf3f94c
Blocks: 1423203
My code in bug 1423840 currently relies on Option<> working with '?', which was added in 1.22. I could modify it to not use that feature without much difficulty, but it would be nice if I didn't have to :)
Blocks: 1423840
FWIW, https://treeherder.mozilla.org/#/jobs?repo=try&revision=0705f935b4c92a819400c62e69a84ead93be8b85 is a try push that contains code using 1.22 features. It's failing to build on Windows and Linux "Bb" jobs.
This bug is currently blocked, so we're going to miss the scheduled bump date. We're waiting on a rust 1.23.0-beta.2 release after rust-lang/rust#46516 lands, which I expect to fix hsivonen/encoding_rs#26. Hopefully that will be soon, but not before the All Hands. If things are on fire, I can do a custom build, but I'd prefer to wait for the upstream release. The "Bb" or "baseline toolchain" builds are in fact there to block code that depends on 1.22 features until this bug can land.
> The "Bb" or "baseline toolchain" builds are in fact there to block code that > depends on 1.22 features until this bug can land. In that case, they are working well! :)
Attachment #8935644 - Flags: review?(core-build-config-reviews)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Depends on: 1424439
This didn't update "mach bootstrap", so not mach bootstrap claims rust is new enough but the actual build fails...
Flags: needinfo?(giles)
Bug 1424439 is updating that
Flags: needinfo?(giles)
I reported bug 1424489 to avoid this situation from happening in the future.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: