Closed
Bug 1423203
Opened 7 years ago
Closed 7 years ago
Update webrender to 22f472f0adb02bd71c472e426e47182f2b218f6d
Categories
(Core :: Graphics: WebRender, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
(Blocks 1 open bug)
Details
(Whiteboard: [wr-mvp] [gfx-noted])
Attachments
(2 files)
+++ This bug was initially created as a clone of Bug #1422317 +++
I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.
When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".
[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
Assignee | ||
Comment 1•7 years ago
|
||
WR @ b7714b1d4348c00682b5643ea0e3f0b15adaeda5
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc9caec29e3b16507d6a83240770b90febdb2d41
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c629e33c91dfd2cce3eb6f271b6523e0f786e4d3
Green so far
Assignee | ||
Comment 2•7 years ago
|
||
WR @ b7714b1d4348c00682b5643ea0e3f0b15adaeda5
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a794f05939dfc5c74c76f5c2607b9f9a1f0e976
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2208c4636c9fd9dd8d1cd8574cdc822d6403c96f
Green so far
Assignee | ||
Comment 3•7 years ago
|
||
WR @ 10bb2a8f028c7a9003f43607d30a24242465435f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d7a0285c606c5bffbe3b05e63d0c48f418d7b2a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2fceaafcef81c0d95d1da0d0356c7cf7c09426ef
Green
Assignee | ||
Comment 4•7 years ago
|
||
WR @ 23d1358c8f94a436d8e591ed001a44a6f51795a1
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc7626f1cf2d606e834e317882bf3fd3a8baeabb
https://treeherder.mozilla.org/#/jobs?repo=try&revision=65f40312756769211591f4594524f5af45b7088a
Green
WR @ f6d91e0a6b7d41add1bf49230101b4f6637c4512
https://treeherder.mozilla.org/#/jobs?repo=try&revision=da24854162a0016f6315a58c045582586c80d2df
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8e3aa1935ef5f654fe298aa779ab2fbb907a73d
OS X build failure, regression range:
* f6d91e0a Auto merge of #2122 - jrmuizel:font-data, r=glennw
* 7bd05c06 Write out font files for CGFonts
* ed7feb0f Split out ResourceGenerator from the other state in YamlFrameWriter
so that's definitely servo/webrender#2122
Assignee | ||
Comment 5•7 years ago
|
||
I filed https://github.com/servo/webrender/pull/2190 to fix the bustage upstream.
Assignee | ||
Comment 6•7 years ago
|
||
WR @ f6d91e0a6b7d41add1bf49230101b4f6637c4512 with that PR applied manually in the patch queue
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ccc49fea95157cbc14a59827c93e74a7943b2a5
https://treeherder.mozilla.org/#/jobs?repo=try&revision=46bfd15db976b160b29191b7ac2d96ef79b98497
OS X builds are green now
Assignee | ||
Comment 7•7 years ago
|
||
WR @ 4ad764b4f364b93a8e08795cde39e313ddabb332
https://treeherder.mozilla.org/#/jobs?repo=try&revision=883bf494ec7dc7058a35f9ba24883d3e76c69e40
green (I only did the linux push)
WR @ b025001e3838119bcb996de55808f052fdbd7420
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f47ce063622bbb3b44033787e420c4c55d85ac9f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b686ec23184833b3b96b2d14eeb06e91112ce4bb
Green so far
Assignee | ||
Comment 8•7 years ago
|
||
WR @ 5756b2ee8bccb5d5364f9c9b2a8c5e4a6aaa622f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0524ad0004641af718ea311b15cd07f8d2a5554
https://treeherder.mozilla.org/#/jobs?repo=try&revision=56577d3dfed47e862daad142d5ffbe88821af913
Green
WR @ b281bd2b324fdb9df61b839aff56651946a6efb3
https://treeherder.mozilla.org/#/jobs?repo=try&revision=311a2ee898548b1df2ff791b026804a533080e32
https://treeherder.mozilla.org/#/jobs?repo=try&revision=60ab81e06a181265bb9a4e5b0f522a783874e182
Green, but a couple of intermittents. I've retriggered them to make sure they're really just intermittents
Assignee | ||
Comment 9•7 years ago
|
||
talos-g1 failure seems persistent, I'll bisect.
Assignee | ||
Comment 10•7 years ago
|
||
This is the backtrace from the log:
thread 'WRRenderBackend#2' panicked at 'index out of bounds: the len is 15 but the index is 52', /checkout/src/liballoc/vec.rs:1552:10
stack backtrace:
0: 0x7f3eb5dda253 - std::sys::imp::backtrace::tracing::imp::unwind_backtrace::h8ed7485deb8ab958
1: 0x7f3eb5dd88ec - std::panicking::default_hook::{{closure}}::h0088fe51b67c687c
2: 0x7f3eb5dd831d - std::panicking::default_hook::hf425c768c5ffbbad
3: 0x7f3eb5dd7e30 - std::panicking::rust_panic_with_hook::h25b934bb4484e9e0
4: 0x7f3eb5dd7cdb - std::panicking::begin_panic::h59483e27e93d7bc6
5: 0x7f3eb5dd7c69 - std::panicking::begin_panic_fmt::h5f221297e8a3dbdb
6: 0x7f3eb5de7ac2 - core::panicking::panic_fmt::h4d1ab9bae1f32475
7: 0x7f3eb5de7638 - core::panicking::panic_bounds_check::h00738207f5476c9a
8: 0x7f3eb5d22cb0 - webrender::tiling::add_to_batch::h74669da3189bb8bb
9: 0x7f3eb5d1e912 - webrender::tiling::<impl webrender::picture::PicturePrimitive>::add_to_batch::h5da34e2c7ef4112e
10: 0x7f3eb5d20c39 - webrender::tiling::add_to_batch::h74669da3189bb8bb
11: 0x7f3eb5d1e912 - webrender::tiling::<impl webrender::picture::PicturePrimitive>::add_to_batch::h5da34e2c7ef4112e
12: 0x7f3eb5d20c39 - webrender::tiling::add_to_batch::h74669da3189bb8bb
13: 0x7f3eb5d1e912 - webrender::tiling::<impl webrender::picture::PicturePrimitive>::add_to_batch::h5da34e2c7ef4112e
14: 0x7f3eb5d20c39 - webrender::tiling::add_to_batch::h74669da3189bb8bb
15: 0x7f3eb5d1e912 - webrender::tiling::<impl webrender::picture::PicturePrimitive>::add_to_batch::h5da34e2c7ef4112e
16: 0x7f3eb5d20c39 - webrender::tiling::add_to_batch::h74669da3189bb8bb
17: 0x7f3eb5d1e912 - webrender::tiling::<impl webrender::picture::PicturePrimitive>::add_to_batch::h5da34e2c7ef4112e
18: 0x7f3eb5d1aa3b - <webrender::tiling::ColorRenderTarget as webrender::tiling::RenderTarget>::build::h75702909112d52ab
19: 0x7f3eb5d0daee - webrender::render_backend::Document::render::h089ba5314e356c2a
20: 0x7f3eb5d00010 - webrender::render_backend::RenderBackend::process_document::h693fce1a0c85d7b1
21: 0x7f3eb5cf12d2 - webrender::render_backend::RenderBackend::run::hf7a1dc471353a036
22: 0x7f3eb5cef8e7 - std::sys_common::backtrace::__rust_begin_short_backtrace::h93ca2084bea4b688
23: 0x7f3eb5ceeef6 - <F as alloc::boxed::FnBox<A>>::call_box::h80d55dfc4829e645
24: 0x7f3eb5de4f33 - std::sys::imp::thread::Thread::new::thread_start::hbaf1b5aa1ca8e3ea
25: 0x7f3ebfbc0e99 - start_thread
26: 0x7f3ebecd038c - clone
Redirecting call to abort() to mozalloc_abort
And this is the WR regression range:
* b281bd2b Auto merge of #2194 - jrmuizel:blob-update-test, r=glennw
|\
| * 55b09865 Add test to make sure that updating blob images updates them
* 983e8fcf Auto merge of #2193 - mbrubeck:deps, r=glennw
|\
| * ae3969ad Update to smallvec 0.6
* f38bf981 Auto merge of #2189 - mrobinson:updated-2177, r=glennw
|\
| * 6b4ddfb2 Add a test for non-axis-aligned clipping
| * 47a70ddc Proper inner rectangle for the clips
* 22f472f0 Merge pull request #2188 from lsalzman/clip-font-transform
* 9c2d2818 fix local clipping of transformed glyphs
WR @ 983e8fcf: https://treeherder.mozilla.org/#/jobs?repo=try&revision=869dbdc392422bab7cde2ec09ff0b09a15576a0f
WR @ f38bf981: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cca0d21990a81a4997276fbfef4a5621159eddcc
WR @ 22f472f0: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e281a859fd216da8d3333eee9bb5552b56dd353
Assignee | ||
Comment 11•7 years ago
|
||
Narrowed to:
* f38bf981 Auto merge of #2189 - mrobinson:updated-2177, r=glennw
|\
| * 6b4ddfb2 Add a test for non-axis-aligned clipping
| * 47a70ddc Proper inner rectangle for the clips
* 22f472f0 Merge pull request #2188 from lsalzman/clip-font-transform
* 9c2d2818 fix local clipping of transformed glyphs
Just waiting on the last push to finish.
Assignee | ||
Comment 12•7 years ago
|
||
Given that the g1 job for WR @ 22f472f0 hasn't failed yet (the others failed in < 5 minutes) I'm assuming it's going to be green, which isolates the regression to servo/webrender#2189.
Will prepare the update to 22f472f0 since that's the last green changeset. Try pushes for that cset to confirm:
WR @ 22f472f0adb02bd71c472e426e47182f2b218f6d
https://treeherder.mozilla.org/#/jobs?repo=try&revision=05b03ab035373f3b2283f626a0525275a4485a22
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f8f1a472ea36773601961a9cc44252174d0c8f8
Assignee | ||
Updated•7 years ago
|
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 15•7 years ago
|
||
mozreview-review |
Comment on attachment 8935804 [details]
Bug 1423203 - Update webrender to commit 22f472f0adb02bd71c472e426e47182f2b218f6d.
https://reviewboard.mozilla.org/r/206672/#review212464
Attachment #8935804 -
Flags: review?(jmuizelaar) → review+
Comment 16•7 years ago
|
||
mozreview-review |
Comment on attachment 8935805 [details]
Bug 1423203 - Update Cargo lockfiles and revendor rust dependencies.
https://reviewboard.mozilla.org/r/206674/#review212468
Attachment #8935805 -
Flags: review?(jmuizelaar) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 19•7 years ago
|
||
^ rebased onto autoland tip to get past mbrubeck's big cleanup.
Comment 20•7 years ago
|
||
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/09af0af978a0
Update webrender to commit 22f472f0adb02bd71c472e426e47182f2b218f6d. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/bdc16b1eab50
Update Cargo lockfiles and revendor rust dependencies. r=jrmuizel
Comment 21•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/09af0af978a0
https://hg.mozilla.org/mozilla-central/rev/bdc16b1eab50
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•