Closed
Bug 1421115
Opened 7 years ago
Closed 7 years ago
Wait for the next event tick before resolving promise in places tests.
Categories
(Firefox :: General, enhancement)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
There are several tests in browser/components/places/tests/ that fails after bug 1193394, because of promise resolution timing.
functions in browser/components/places/tests/browser/head.js needs to wait for the next event tick before resolving promise in event handler.
|
Assignee | |
Comment 1•7 years ago
|
||
promiseLibraryClosed and withSidebarTree should wait for the next event tick before resolving the promise inside unload/load event handler,
to avoid the remaining part of the testcase runs unexpectedly earlier,
after the change in bug 1193394.
Attachment #8932838 -
Flags: review?(mak77)
|
||
Updated•7 years ago
|
Attachment #8932838 -
Flags: review?(mak77) → review+
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/efd54930bcdf
Wait for the next event tick before resolving promise in places tests. r=mak
|
|
Assignee | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/efd54930bcdf3e5c6996634f82c71f5abaea7009
Bug 1421115 - Wait for the next event tick before resolving promise in places tests. r=mak
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in
before you can comment on or make changes to this bug.
Description
•