Closed
Bug 1421118
Opened 7 years ago
Closed 7 years ago
Wait for the next event tick before resolving promise in preferences test.
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5800bb624450f22893e4918d653b3dbe231c4ac&selectedJob=147752924
> TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_cookies_exceptions.js | site should be sorted. 'z' should be first - Got http://a, expected http://z
after fixing bug 1193394, the test needs to wait for the next event tick before resolving promise in dialogopen event, to make sure everything gets ready.
Assignee | ||
Comment 1•7 years ago
|
||
promiseLoadSubDialog should wait for the next event tick before resolving the promise inside dialogopen event handler,
to avoid the remaining part of the testcase runs unexpectedly earlier,
after the change in bug 1193394.
Attachment #8932841 -
Flags: review?(jaws)
Comment 2•7 years ago
|
||
Comment on attachment 8932841 [details] [diff] [review]
Wait for the next event tick before resolving promise in preferences test.
Review of attachment 8932841 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/components/preferences/in-content/tests/head.js
@@ +66,5 @@
> }
> }
> is(expectedStyleSheetURLs.length, 0, "All expectedStyleSheetURLs should have been found");
>
> + executeSoon(() => resolve(aEvent.detail.dialog._frame.contentWindow));
Can you please add a comment to the test explaining why we need to wait for the next tick here?
Attachment #8932841 -
Flags: review?(jaws) → review+
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/451c5350e986
Wait for the next event tick before resolving promise in preferences test. r=jaws
Assignee | ||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/451c5350e9867e973c0b7f97ab7790b6a551f8ca
Bug 1421118 - Wait for the next event tick before resolving promise in preferences test. r=jaws
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in
before you can comment on or make changes to this bug.
Description
•