Closed
Bug 1421653
Opened 7 years ago
Closed 7 years ago
browser/base/content/test/general/browser_trackingUI_5.js should wait for new tab load event before starting test on the tab
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
browser/base/content/test/general/browser_trackingUI_5.js starts testing on new tab just after adding the new tab, that results in triggering page load in unstable state,
and the finally loaded page can differ depending on the timing.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 1•7 years ago
|
||
this test deterministically fails with non-e10s locally, after bug 1193394.
so I think there's some more issue there.
Assignee | ||
Comment 2•7 years ago
|
||
On non-e10s, the tracking protection is disabled (just like unblock button is clicked) at the beginning of testExceptionPersistence.
and commenting out testExceptionAddition except `await UrlClassifierTestUtils.addTestTrackers(); await pushPrefs([PB_PREF, true]);` solves the issue.
So I think there's some unexpected interaction between those 2 tests.
Assignee | ||
Comment 3•7 years ago
|
||
turns out that it should also wait for the close of private window.
Assignee | ||
Comment 4•7 years ago
|
||
promiseWindowWillBeClosed needs executeSoon just like other cases.
also, the test should wait for the tab's load event to run in stable state,
by using BrowserTestUtils.openNewForegroundTab instead of browser.addTab.
Attachment #8933526 -
Flags: review?(felipc)
Updated•7 years ago
|
Attachment #8933526 -
Flags: review?(felipc) → review+
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/04761f378126
Wait for new tab load and window close in browser/base/content/test/general/browser_trackingUI_5.js to make sure state transition does not overlap. r=felipe
Assignee | ||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/04761f378126ee866a1a25807782e9d504bade4b
Bug 1421653 - Wait for new tab load and window close in browser/base/content/test/general/browser_trackingUI_5.js to make sure state transition does not overlap. r=felipe
Comment 7•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in
before you can comment on or make changes to this bug.
Description
•