Closed
Bug 1421903
Opened 7 years ago
Closed 7 years ago
Allow default packaged top site rich icons to be used for non-root pages
Categories
(Firefox :: New Tab Page, enhancement, P2)
Firefox
New Tab Page
Tracking
()
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Attachments
(2 files)
defaults vs current vs always default vs conditional default
r1cky noted that tippy top behavior is to apply to all pages on a given domain/www-domain, but the default icons have logic to restrict it to "/". It seems that if we expand the packaged rich icon usage, it could avoid requesting tippy top metadata if frecent top sites only included pages from the defaults.
|
Assignee | |
Updated•7 years ago
|
Priority: -- → P2
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → edilee
|
|
Assignee | |
Comment 1•7 years ago
|
||
I believe we should probably first use any rich icon from the site even if it's different from our packaged default top site icons as potentially there could be a purposefully different icon for a given page. (The last option of attached.)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Oh, and I couldn't find any non-root pages on www.wikipedia.org…
|
||
Comment 3•7 years ago
|
||
|
||
Comment 4•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/ce92c43ba20c2f2cc7b18b75ab1b2de3eeab84f9
feat(tippytop): Use default top icons if a site lacks a rich icon (#3890)
Fix Bug 1421903 - Allow default packaged top site rich icons to be used for non-root pages
|
|
||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•7 years ago
|
Iteration: 1.26 → 1.25
|
|
Assignee | |
Comment 5•7 years ago
|
||
Target Milestone: --- → Firefox 59
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•