Closed
Bug 1423810
Opened 7 years ago
Closed 7 years ago
regression: a right click automatically opens and closes the context menu and let me go back
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox57 | --- | unaffected |
firefox58 | --- | unaffected |
firefox59 | --- | fixed |
People
(Reporter: jan, Assigned: stransky)
References
Details
(Keywords: nightly-community, regression)
Attachments
(2 files)
Nightly 59 x64 20171206221407 de_DE @ Debian Testing (KDE, Radeon RX480)
fresh profile
STR
1. open https://www.mozilla.org/en-US/firefox/nightly/firstrun/
2. then open https://bugzilla.mozilla.org in the same tab
3. do a rightclick.
(If I hold down the right mouse button the context menu won't immediately disappear and run some action.)
mozregression --good 2017-12-05 --bad 2017-12-06
> 5:02.34 INFO: Last good revision: a27e933a27b65f220dabf6a5949ce15003485fd6
> 5:02.34 INFO: First bad revision: ed817bc6cc3bc2a11e9607afb3c5b52702ceb12a
> 5:02.34 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a27e933a27b65f220dabf6a5949ce15003485fd6&tochange=ed817bc6cc3bc2a11e9607afb3c5b52702ceb12a
> ed817bc6cc3b Martin Stransky — Bug 1421974 - use gtk_window_set_titlebar() to hide titlebar on WM where GDK_DECOR_BORDER does not work, r=jhorak
> 663151801680 Martin Stransky — Bug 1421974 - refactor nsWindow::HideWindowChrome() to nsWindow::SetWindowDecoration() and share it with nsWindow::SetDrawsInTitlebar, r=jhorak
Flags: needinfo?(stransky)
Reporter | ||
Updated•7 years ago
|
Has Regression Range: --- → yes
Has STR: --- → yes
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → stransky
Assignee | ||
Comment 2•7 years ago
|
||
We hit a bug when mContainer has a different origin than mShell - that's when CSD is active or the CSD titlebar mode is enabled.
Assignee | ||
Comment 5•7 years ago
|
||
Bug 1423869 should partially fix that for gnome-shell and Cinamon. Other systems can use a workaround and run "$MOZ_GTK_TITLEBAR_DECORATION=none ./firefox" when patches from Bug 1423869 lands.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•7 years ago
|
||
I don't have the fix now as it's more complicated than I expected. Let's disable CSD decorations to fix the regression. This workaround needs patch from Bug 1423869.
Depends on: 1423869
Should we be backing out the work from bug 1421974, in the meantime? Is that the cause (as suggested in bug 1424110)?
Flags: needinfo?(stransky)
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8936303 [details]
Bug 1423810 - Temporary disable CSD decoration as it breaks popup windows,
https://reviewboard.mozilla.org/r/207036/#review212926
Attachment #8936303 -
Flags: review?(jhorak) → review+
Assignee | ||
Comment 11•7 years ago
|
||
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #8)
> Should we be backing out the work from bug 1421974, in the meantime? Is
> that the cause (as suggested in bug 1424110)?
Yes, bug 1421974 causes this regression but we can disable only the broken part, which does the patch here.
Flags: needinfo?(stransky)
Comment 12•7 years ago
|
||
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/114cd5adf270
Temporary disable CSD decoration as it breaks popup windows, r=jhorak
Comment 13•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Assignee | ||
Comment 14•7 years ago
|
||
Follow up bug for full fix Bug 1424974.
Comment 16•7 years ago
|
||
Now that the full fix is finished, shouldn't CSD be turned back on?
You need to log in
before you can comment on or make changes to this bug.
Description
•