Closed
Bug 1425003
Opened 7 years ago
Closed 7 years ago
GeckoViewNavigation.jsm references undefined URIFIxup
Categories
(GeckoView :: General, defect)
GeckoView
General
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
GeckoViewNavigation.jsm is currently referencing `URIFixup.createExposableURI(locationURI);` however URIFixup is not defined in the file.
It looks like a bad cut/paste when this file was created.
This was picked up when experimenting with turning on ESLint's no-undef rule in mobile/android.
The fix is quite simple, though I think we should swap to Services.urifixup as the rest of mozilla-central code has.
I'll get a patch up in a bit.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
Note: I've not tested this, but ESLint is happy with the fix...
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8936596 [details]
Bug 1425003 - Fix GeckoViewNavigation.jsm referencing undefined URIFIxup - switch to Services.uriFixup.
https://reviewboard.mozilla.org/r/207356/#review213900
Attachment #8936596 -
Flags: review?(snorp) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67c2ae51ba58
Fix GeckoViewNavigation.jsm referencing undefined URIFIxup - switch to Services.uriFixup. r=snorp
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•6 years ago
|
Target Milestone: Firefox 59 → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•