Closed Bug 1425033 Opened 7 years ago Closed 7 years ago

FormAssistant.jsm references undefined 'content' variable

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: standard8, Assigned: jchen)

References

Details

(Keywords: regression)

Caught via looking at enabling ESLint, in FormAssistant#_getBoundingContentRect: ``` for (let frame = aElement.ownerGlobal; frame.frameElement && frame != content; frame = frame.parent) { ``` However, since the code moved from browser.js to a .jsm, `content` is undefined.
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8652c5609292 Fix frame handling in FormAssistant; r=me
https://hg.mozilla.org/mozilla-central/rev/8652c5609292
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
I assume that this is something that can ride the trains, but feel free to set the status for 58 back to affected and nominate the patch for approval if you feel strongly otherwise.
status-firefox57: --- → wontfix
status-firefox58: --- → wontfix
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.