Closed Bug 1425047 Opened 7 years ago Closed 5 years ago

Enable ESLint rule no-undef for mobile/android/chrome

Categories

(Firefox for Android Graveyard :: General, enhancement, P5)

Product:
Firefox for Android Graveyard
Component:
General
Type:
enhancement

Tracking

(firefox74 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(4 files)

Bug 1425047 - Enable ESLint rules no-undef and no-unused-vars for mobile/android/chrome/geckoview. r?esawin
(deleted), text/x-phabricator-request
Details
Bug 1425047 - Enable already passing rules for mobile/android. r?esawin
(deleted), text/x-phabricator-request
Details
Bug 1425047 - Enable ESLint rule object-shorthand for mobile/android. r?esawin
(deleted), text/x-phabricator-request
Details
Bug 1425047 - Enable rest of ESLint rules for mobile/android. r?esawin
(deleted), text/x-phabricator-request
Details
Currently the mobile/android/chrome directory reports a lot of no-undef issues. I think a lot of these are the fact that ESLint doesn't know the actual globals that are available. It might be that we need something equivalent to the browser-window environment (that we use for browser/base/content), that works out the mobile globlals.
Priority: -- → P3
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195 Needinfo :susheel if you think this bug should be re-triaged.
Priority: P3 → P5

With the various removals that have gone on and mainly just geckoview left, there's no much to do here to enable the no-undef and no-unused-vars rules.

Additionally, getting the other rules passing that we didn't have passing before is also easy to do.

Hence, I've just done a few patches to get this tidied up. The only bit of remaining enabling would be bug 1424996, but that didn't seem worth it as bug 1583370 will likely make that bit go away.

Assignee: nobody → standard8
Status: NEW → ASSIGNED
Iteration: --- → 74.2 - Jan 20 - Feb 09
Points: --- → 2

This enables consistent-return, no-empty and no-redeclare.

Depends on D60826

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dfe93fc476bd Enable ESLint rules no-undef and no-unused-vars for mobile/android/chrome/geckoview. r=esawin https://hg.mozilla.org/integration/autoland/rev/cba96b50b796 Enable already passing rules for mobile/android. r=esawin https://hg.mozilla.org/integration/autoland/rev/f9f175845e62 Enable ESLint rule object-shorthand for mobile/android. r=esawin https://hg.mozilla.org/integration/autoland/rev/bd96768e10b9 Enable rest of ESLint rules for mobile/android. r=esawin
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: