Closed Bug 1425048 Opened 7 years ago Closed 2 years ago

Enable ESLint rule no-undef for mobile/android/components/extensions/

Categories

(GeckoView :: Extensions, enhancement, P5)

Product:
GeckoView
Component:
Extensions
Type:
enhancement

Tracking

(firefox112 wontfix, firefox113 wontfix, firefox114 fixed)

Status:
RESOLVED FIXED
Milestone:
114 Branch
Tracking Flags:
Tracking Status
firefox112 --- wontfix
firefox113 --- wontfix
firefox114 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Bug 1425048 - Enable ESLint rules no-unused-vars/no-undef for mobile/android/components/extensions/. r?m_kato!,robwu!
(deleted), text/x-phabricator-request
Details
Currently the mobile/android/components/extensions/ directory reports a lot of no-undef issues. Most of this will be determining which files are "importing" globals from other files.
Priority: -- → P3
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195 Needinfo :susheel if you think this bug should be re-triaged.
Priority: P3 → P5

Bug 1583370 is likely going to remove this code.

Depends on: 1583370
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard

This bug is still valid for GeckoView: https://searchfox.org/mozilla-central/rev/55d5c4b9dffe5e59eb6b019c1a930ec9ada47e10/mobile/android/.eslintrc.js#10-18

Bug 1583370 didn't remove the code.

Status: RESOLVED → REOPENED
Product: Firefox for Android Graveyard → GeckoView
Resolution: INCOMPLETE → ---
Assignee: nobody → standard8
Severity: normal → N/A
Component: General → Extensions
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d3b346e7cdd0 Enable ESLint rules no-unused-vars/no-undef for mobile/android/components/extensions/. r=geckoview-reviewers,extension-reviewers,robwu,owlish

https://hg.mozilla.org/mozilla-central/rev/d3b346e7cdd0

Status: REOPENED → RESOLVED
Closed: 4 years ago → 2 years ago
status-firefox114: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: