Closed Bug 1426931 Opened 7 years ago Closed 7 years ago

Stop sites from abusing the confirm repost dialog

Categories

(Firefox :: Security, defect)

57 Branch
defect
Not set
critical

Tracking

()

RESOLVED DUPLICATE of bug 1412559

People

(Reporter: cdalxndr, Unassigned)

Details

Attachments

(1 file)

(deleted), application/x-7z-compressed
Details
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 Build ID: 20171206182557 Steps to reproduce: Access http://surfingdefenderext.biz/ff/ This is not my site. It is a malicious pop-up I encountered. Press X for "Confirm", than "X" for "Authentication Required". Actual results: Stuck in Confirm dialog loop, and cannot close this tab, or any other tabs in this windows. Expected results: After some confirms, the dialog should be blocked and shown a firefox specific confirmation message to allow or deny further dialogs.
Severity: normal → blocker
Attached file Saved malicious web page (deleted) —
Blocks: eviltraps
Severity: blocker → critical
Attachment #8938712 - Attachment mime type: text/html → application/x-7z-compressed
Component: Untriaged → Security
This and other variants of this page seem to be super popular at the moment. The page should not be able to trigger the repost confirm page repeatedly. Last two days: https://www.reddit.com/r/firefox/comments/7n9z7x/anyone_experienced_something_like_this_ad_is/ https://www.reddit.com/r/firefox/comments/7mu881/malicious_type_of_ad_renders_firefox_locked_and/
It seems like the code is supposed to only trigger that dialog for user-initiated, but the page seems to trigger it with an iframe that calls top.reload? https://searchfox.org/mozilla-central/rev/5776cdf83b662f9333d9d20cfcb39119fa69678e/docshell/base/nsDocShell.cpp#11982
Flags: needinfo?(bzbarsky)
Summary: Malicious pop-up blocks all tabs in confirm loop → Stop sites from abusing the confirm repost dialog
Status: UNCONFIRMED → NEW
Ever confirmed: true
Fixed in 58 but we didn't dare the release uplift...
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(bzbarsky)
Resolution: --- → DUPLICATE
No longer blocks: eviltraps
Nice! So we only need bug 613785 now.
Yeah, ideally everything tracked in bug 616843 (and 432687, for that matter).
Still an issue with "https://helpfoxpro.com/update/". After closing the authentication dialog and moving the mouse to the upper side of page (trying to close it) it reappears and blocks whole window again. Firefox 59.0.3 (64bit)
(In reply to cdalxndr from comment #7) > Still an issue with "https://helpfoxpro.com/update/". > After closing the authentication dialog and moving the mouse to the upper > side of page (trying to close it) it reappears and blocks whole window > again. > Firefox 59.0.3 (64bit) Yup, that's bug 613785.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: