Closed Bug 1429946 Opened 7 years ago Closed 4 years ago

Use folderPane.js to convert SeaMonkeys rdf-trees to js

Categories

(SeaMonkey :: MailNews: Message Display, enhancement)

Product:
SeaMonkey
Component:
MailNews: Message Display
Type:
enhancement
Priority:
Not set
Severity:
blocker

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.87
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: frg, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.8)

Attachments

(1 file)

1429946-port464710-2538.patch
(deleted), patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
XUL template and datasource rdf removal broke SeaMonkey Mail/News completly. Unless we want to reinvent the wheel or someone has a better less costly idea we need to switch to Thunderbirds folderpane.js. +++ This bug was initially created as a clone of Bug #464710 +++ This is the first real test of the js-folder-pane's extensibility. The offline-folders dialog, along with the saved-search scope dialog each want to display trees of folders, though not the specific lists of folders provided by the main-window's modes. These patches show how to add additional modes to folderPane.js, and thereby eliminates these rdf-driven trees. Note that these changes were in the kill-rdf branch as 654:41ed0521f6f8 and 656:cf3baa820a87
Oh btw the sidebar and help viewer are also broken :(
Blocks: SM-killrdf
No longer blocks: 2.57BulkMalfunctions
Assignee: nobody → iann_bugzilla
Component: MailNews: General → MailNews: Message Display
Depends on: 507601
Attached patch 1429946-port464710-2538.patch (deleted) — — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): 464710
User impact if declined: virtual / offline doesn't work / display properly
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Attachment #9210528 - Flags: review?(frgrahl)
Attachment #9210528 - Flags: approval-comm-release?
Attachment #9210528 - Flags: approval-comm-esr60?
Status: NEW → ASSIGNED

Comment on attachment 9210528 [details] [diff] [review]
1429946-port464710-2538.patch

LGTM

Attachment #9210528 - Flags: review?(frgrahl)
Attachment #9210528 - Flags: review+
Attachment #9210528 - Flags: approval-comm-release?
Attachment #9210528 - Flags: approval-comm-release+
Attachment #9210528 - Flags: approval-comm-esr60?
Attachment #9210528 - Flags: approval-comm-esr60+
status-seamonkey2.53: --- → affected
status-seamonkey2.56: affected → ---
status-seamonkey2.57esr: --- → affected
tracking-seamonkey2.53: --- → ?
tracking-seamonkey2.57esr: --- → ?
Version: SeaMonkey 2.56 Branch → Trunk

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/5ce8529cbffc
Use folderPane.js to convert SeaMonkeys rdf-trees to js. r=frg

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: SM2.53.8
Target Milestone: --- → seamonkey 2.87
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: