Jorg, there will need to be some Thunderbird changes here too. See https://searchfox.org/comm-central/search?q=-%3ESetAttribute%28&case=true&path=mailnews and https://searchfox.org/comm-central/search?q=-%3EHasAttribute%28&case=true&path=mailnews and https://searchfox.org/comm-central/search?q=-%3EGetAttribute%28&case=true&path=mailnews

The only C++ caller doesn't care, and JS callers can't tell that a non-NS_OK success code was returned anyway. MozReview-Commit-ID: FNhQYR0a9ur

The only C++ caller immediately QIs the result anyway, and the exact type returned doesn't matter for JS callers because the return values are DOM objects. This makes it simpler to rejigger the internals to work with nsINode and Element and whatnot. MozReview-Commit-ID: 863IDGECqYY

MozReview-Commit-ID: EAEzpom7oXo

MozReview-Commit-ID: 3F1rbPMgkAR

MozReview-Commit-ID: CDnYK194JB9

MozReview-Commit-ID: 4KlppKdzJGy

MozReview-Commit-ID: 8rmd120L2BK

MozReview-Commit-ID: 926Dzqv7Oj4

MozReview-Commit-ID: KDeeVkeRmQr

MozReview-Commit-ID: 6eIdX8iA5Rg

MozReview-Commit-ID: 2f1vFvRdCPG

MozReview-Commit-ID: K6w7FR254UC

MozReview-Commit-ID: 8A1VcWArVcP

MozReview-Commit-ID: K6w7FR254UC

Comment on attachment 8945301 [details] [diff] [review] part 11. Remove nsIDOMElement::GetAttribute Review of attachment 8945301 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/xul/tree/nsTreeContentView.cpp @@ +249,5 @@ > nsAString& aProperties) > { > + IgnoredErrorResult rv; > + RefPtr<Element> element = aColumn.GetElement(rv); > + nit: trailing whitespace.

> nit: trailing whitespace. Fixed.

Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/93c1d149d757 part 1. Stop returning NS_EDITOR_ELEMENT_NOT_FOUND from nsIHTMLEditor::GetSelectedElement. r=m_kato https://hg.mozilla.org/integration/mozilla-inbound/rev/15f093275a0d part 2. Make nsIHTMLEditor.getSelectedElement return nsISupports. r=m_kato https://hg.mozilla.org/integration/mozilla-inbound/rev/84d651460f98 part 3. Take an early return from HTMLEditor::GetSelectedElement when we can. r=m_kato https://hg.mozilla.org/integration/mozilla-inbound/rev/8d4336d56112 part 4. Work with Element, not nsIDOMElement, inside HTMLEditor::GetSelectedElement. r=m_kato https://hg.mozilla.org/integration/mozilla-inbound/rev/7587d756a885 part 5. Remove the now-unused nsIDOMNode overload of HTMLEditUtils::IsLink. r=m_kato https://hg.mozilla.org/integration/mozilla-inbound/rev/3524d4390de9 part 6. Remove the nsIDOMNode overloads of HTMLEditUtils::IsNamedAnchor and HTMLEditUtils::IsTable. r=m_kato https://hg.mozilla.org/integration/mozilla-inbound/rev/2b200ba1a37e part 7. Remove nsIDOMElement's tagName attribute. r=mccr8 https://hg.mozilla.org/integration/mozilla-inbound/rev/e7ad723a13ff part 8. Remove usage of nsIDOMElement::HasAttribute in editor code. r=m_kato https://hg.mozilla.org/integration/mozilla-inbound/rev/a5250222f3d5 part 9. Remove nsIDOMElement::HasAttribute. r=mccr8 https://hg.mozilla.org/integration/mozilla-inbound/rev/a59431cb28a1 part 10. Remove nsIDOMElement::SetAttribute. r=mccr8 https://hg.mozilla.org/integration/mozilla-inbound/rev/76c001daf265 part 11. Remove nsIDOMElement::GetAttribute. r=mccr8 https://hg.mozilla.org/integration/mozilla-inbound/rev/e723bf17f405 part 12. Change nsIFormProcessor to pass Element, not nsIDOMHTMLElement, for elements. r=mccr8 https://hg.mozilla.org/integration/mozilla-inbound/rev/f01a1eb49c2e part 13. Remove the NS_FORWARD_NSIDOMELEMENT_TO_GENERIC macro. r=mccr8

https://hg.mozilla.org/mozilla-central/rev/93c1d149d757 https://hg.mozilla.org/mozilla-central/rev/15f093275a0d https://hg.mozilla.org/mozilla-central/rev/84d651460f98 https://hg.mozilla.org/mozilla-central/rev/8d4336d56112 https://hg.mozilla.org/mozilla-central/rev/7587d756a885 https://hg.mozilla.org/mozilla-central/rev/3524d4390de9 https://hg.mozilla.org/mozilla-central/rev/2b200ba1a37e https://hg.mozilla.org/mozilla-central/rev/e7ad723a13ff https://hg.mozilla.org/mozilla-central/rev/a5250222f3d5 https://hg.mozilla.org/mozilla-central/rev/a59431cb28a1 https://hg.mozilla.org/mozilla-central/rev/76c001daf265 https://hg.mozilla.org/mozilla-central/rev/e723bf17f405 https://hg.mozilla.org/mozilla-central/rev/f01a1eb49c2e