Closed
Bug 1432977
Opened 7 years ago
Closed 7 years ago
Remove all members from nsIDOMHTMLElement
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(3 files)
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
MozReview-Commit-ID: Gj8thsaNGCF
Attachment #8945305 -
Flags: review?(continuation)
Assignee | ||
Comment 2•7 years ago
|
||
MozReview-Commit-ID: B07hMx3LAed
Attachment #8945306 -
Flags: review?(continuation)
Assignee | ||
Comment 3•7 years ago
|
||
MozReview-Commit-ID: EoSwBkeGj60
Attachment #8945307 -
Flags: review?(continuation)
Updated•7 years ago
|
Priority: -- → P2
Updated•7 years ago
|
Attachment #8945305 -
Flags: review?(continuation) → review+
Updated•7 years ago
|
Attachment #8945306 -
Flags: review?(continuation) → review+
Comment 4•7 years ago
|
||
Comment on attachment 8945307 [details] [diff] [review]
part 3. Remove nsIDOMHTMLElement's offsetWidt/Height attributes
Review of attachment 8945307 [details] [diff] [review]:
-----------------------------------------------------------------
nit: "offsetWidt" in the patch summary.
::: dom/interfaces/html/nsIDOMHTMLElement.idl
@@ +7,3 @@
>
> /**
> * The nsIDOMHTMLElement interface is the primary [X]HTML element
Is this comment still useful?
::: editor/libeditor/HTMLInlineTableEditor.cpp
@@ +202,5 @@
> {
> if (!mInlineEditedCell) {
> return NS_OK;
> }
> +
nit: trailing whitespace.
Attachment #8945307 -
Flags: review?(continuation) → review+
Assignee | ||
Comment 5•7 years ago
|
||
> nit: "offsetWidt" in the patch summary.
Fixed.
> Is this comment still useful?
This while file dies in bug 1418085 so I'm not going to worry about it. ;)
> nit: trailing whitespace.
Fixed.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0759dfa715e
part 1. Remove nsIDOMHTMLElement's draggable attribute. r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/b99a55d47c97
part 2. Remove nsIDOMHTMLElement's spellcheck attribute. r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1deaf1c9d50
part 3. Remove nsIDOMHTMLElement's offsetWidth/Height attributes. r=mccr8
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e0759dfa715e
https://hg.mozilla.org/mozilla-central/rev/b99a55d47c97
https://hg.mozilla.org/mozilla-central/rev/c1deaf1c9d50
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•