Closed Bug 1433059 Opened 7 years ago Closed 5 years ago

Raise BadZipfile, "File is not a zip file"

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nataliaCs, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell infra])

Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=158398276&repo=autoland&lineNumber=128 Push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=9a6d7da2f9b1949d649875a1e413b76c65c14857&selectedJob=158398276 08:00:30 FATAL - Traceback (most recent call last): 129 08:00:30 FATAL - 130 08:00:30 FATAL - File "Z:\task_1516866747\mozharness\mozharness\base\script.py", line 712, in download_unpack 131 08:00:30 FATAL - function(**kwargs) 132 08:00:30 FATAL - 133 08:00:30 FATAL - File "Z:\task_1516866747\mozharness\mozharness\base\script.py", line 581, in unzip 134 08:00:30 FATAL - with zipfile.ZipFile(compressed_file) as bundle: 135 08:00:30 FATAL - 136 08:00:30 FATAL - File "c:\mozilla-build\python\lib\zipfile.py", line 770, in __init__ 137 08:00:30 FATAL - self._RealGetContents() 138 08:00:30 FATAL - 139 08:00:30 FATAL - File "c:\mozilla-build\python\lib\zipfile.py", line 811, in _RealGetContents 140 08:00:30 FATAL - raise BadZipfile, "File is not a zip file" 141 08:00:30 FATAL - 142 08:00:30 FATAL - BadZipfile: File is not a zip file 143 08:00:30 FATAL - 144 08:00:30 FATAL - Running post_fatal callback... 145 08:00:30 FATAL - Exiting -1
Thanks for the additional details. As filed a few hours ago, this bug had absolutely no actionable information and I tried to close it as INVALID. Cloning old bugs is usually not helpful, as it drags in old information (comment 0) and old dependencies / blockers.
No longer blocks: 1266624
No longer depends on: 1309907, 1306189, 1307177, 1320938
From the content-length of 282 bytes, it looks like this was an error response, perhaps from AWS as I don't see it in cloud-mirror or queue logs. In theory, the mozharness code should retry those, so I don't know why that didn't occur here. 08:00:29 INFO - retry: Calling fetch_url_into_memory with args: (), kwargs: {'url': 'https://queue.taskcluster.net/v1/task/OxZwR7cZS1CD_0bUoMjFQA/artifacts/public/build/target.crashreporter-symbols.zip'}, attempt #1 08:00:29 INFO - Fetch https://queue.taskcluster.net/v1/task/OxZwR7cZS1CD_0bUoMjFQA/artifacts/public/build/target.crashreporter-symbols.zip into memory 08:00:30 INFO - Content-Length response header: 282 08:00:30 INFO - Bytes received: 282
Component: General → Mozharness
Product: Taskcluster → Release Engineering
QA Contact: catlee
Sounds like bug 1364463.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
https://treeherder.mozilla.org/logviewer.html#?job_id=191219187&repo=autoland 19:52:02 INFO - Bytes received: 282 19:52:02 FATAL - Traceback (most recent call last): 19:52:02 FATAL - 19:52:02 FATAL - File "Z:\task_1533066438\mozharness\mozharness\base\script.py", line 729, in download_unpack 19:52:02 FATAL - function(**kwargs) 19:52:02 FATAL - 19:52:02 FATAL - File "Z:\task_1533066438\mozharness\mozharness\base\script.py", line 598, in unzip 19:52:02 FATAL - with zipfile.ZipFile(compressed_file) as bundle: 19:52:02 FATAL - 19:52:02 FATAL - File "c:\mozilla-build\python\lib\zipfile.py", line 770, in __init__ 19:52:02 FATAL - self._RealGetContents() 19:52:02 FATAL - 19:52:02 FATAL - File "c:\mozilla-build\python\lib\zipfile.py", line 811, in _RealGetContents 19:52:02 FATAL - raise BadZipfile, "File is not a zip file" 19:52:02 FATAL - 19:52:02 FATAL - BadZipfile: File is not a zip file 19:52:02 FATAL - 19:52:02 FATAL - Running post_fatal callback... 19:52:02 FATAL - Exiting -1 19:52:02 INFO - Running post-action listener: _resource_record_post_action 19:52:02 INFO - Running post-action listener: find_tests_for_coverage 19:52:02 INFO - Running post-action listener: find_tests_for_verification 19:52:02 INFO - Running post-action listener: set_extra_try_arguments 19:52:02 INFO - Running post-action listener: setup_coverage_tools 19:52:02 INFO - [mozharness: 2018-07-31 19:52:02.794000Z] Finished download-and-extract step (failed) 19:52:02 INFO - Running post-run listener: _resource_record_post_run 19:52:02 INFO - Running post-run listener: copy_logs_to_upload_dir 19:52:02 INFO - Copying logs to upload dir... 19:52:02 INFO - mkdir: Z:\task_1533066438\build\upload\logs [taskcluster 2018-07-31T19:52:02.860Z] Exit Code: -1
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Component: Applications: MozharnessCore → Queue
Product: Release Engineering → Taskcluster
Blocks: 1364463
Component: Queue → Services

This is a bug in mozharness -- it should be checking the response code before trying to decode the body. At least, that's my understanding.

Component: Services → Applications: MozharnessCore
Product: Taskcluster → Release Engineering

Ah, but if this was bug 1364463 then that's fixed by virtue of cloud-mirror being dead. Let's call this FIXED :)

Status: REOPENED → RESOLVED
Closed: 7 years ago5 years ago
Resolution: --- → FIXED

Gzip, renaming, tracing, and 7zip expressions are the most basic ways to overcome the problem (Zipfile.badzipfile: file is not a zip) in Python. In fact, these two options necessitate the installation of new modules. Read here more https://www.kodlogs.net/326/zipfile-badzipfile-file-is-not-a-zip

You need to log in before you can comment on or make changes to this bug.