Closed Bug 1433209 Opened 7 years ago Closed 6 years ago

Remove unused strings to simplify translating

Categories

(Firefox :: New Tab Page, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 60
Iteration:
60.4 - Mar 12
Tracking Status
firefox60 --- fixed

People

(Reporter: Mardak, Assigned: andreio)

References

Details

(Whiteboard: [strings landed][AS60MVP])

Attachments

(1 file)

From https://github.com/mozilla/activity-stream/issues/3314

Now that Test Pilot is done development and self destructed in #3143, we can remove unused strings that aren't used or won't be used by the system addon. This makes it easier for locales that haven't finished translating as per #3274 (comment)

>    Yes please. There's one major pro: some locales might have not translated those strings, and will if they decide to start or finish translating AS.
Whiteboard: [AS60MVP]
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/aea9fdbcfda23914cc062ed4bb194a042af9371c
chore(l10n): Update localization comments based on reviews (#3955)

These following strings are currently unused in 60 and should be removed as part of bug 1433209:
edit_topsites_button_label=Customize your Top Sites section
edit_topsites_showmore_button=Show More
edit_topsites_showless_button=Show Fewer
edit_topsites_done_button=Done
edit_topsites_pin_button=Pin this site
edit_topsites_unpin_button=Unpin this site
edit_topsites_dismiss_button=Dismiss this site
This string is currently unused in 60 and should be removed as part of this bug:
edit_topsites_add_button
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/a9345db2d358c808c011f6835e1084f84eec8afd
feat (sections) - remove info option code

The following strings can be removed after Firefox 60:
* section_info_option
* section_info_privacy_notice
* pocket_feedback_header

(Ping Bug 1433209)
Assignee: nobody → andrei.br92
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
This shouldn't have been merged yet.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Whiteboard: [AS60MVP] → [strings needed][AS60MVP]
Status: ASSIGNED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Blocks: 1444522
Blocks: 1445090
Whiteboard: [strings needed][AS60MVP] → [strings landed][AS60MVP]
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: